Fiix getArray mistake in CondIsTagged, add runtime error for bad namespace keys in ExprTag #7474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sovdeeth
added
the
bug
UnderscoreTud
approved these changes
Jan 19, 2025
Efnilite
approved these changes
Jan 19, 2025
Efnilite
added
the
patch-ready
ShaneBeee
suggested changes
Jan 20, 2025
Comment on lines
+103
to
+107
| error("Invalid tag key: '" + name + "'. Tags may only contain a-z, 0-9, _, ., or - characters."); | ||
| continue; | ||
| } | ||
| if (key == null) | ||
| if (key == null) { | ||
| error("Invalid tag key: '" + name + "'. Tags may only contain a-z, 0-9, _, ., or - characters."); |
There was a problem hiding this comment.
NamespacedKeys can also contain /
| register a custom item tag named "or_list_tag_2" using spruce log | ||
|
|
||
| loop 10 times: | ||
| assert oak log is tagged as custom tag "or_list_tag_1" or custom tag "or_list_tag_2" |
There was a problem hiding this comment.
I believe the original issue was relating to tag A or B?!?!
Maybe add another check:
assert oak log is tagged as custom tag "or_list_tag_1" or "or_list_tag_2"
I could be totally wrong here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
changes getArray to getAnd in CondIsTagged to fix #7471
adds runtime error to catch invalid tags in ExprTag
Target Minecraft Versions: any
Requirements: none
Related Issues: #7471