Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No updates? #14

Open
marijnhurkens opened this issue Dec 8, 2020 · 4 comments
Open

No updates? #14

marijnhurkens opened this issue Dec 8, 2020 · 4 comments

Comments

@marijnhurkens
Copy link

SlimPay is still an active company right? I see this repository hasn't been updated since 3 years, while the default rest api guide still points to this client: https://dev.slimpay.com/hapi/guide/30-min-integration/easy-step-by-step

How is this possible?

Anyway: the project is not compatible with Guzzle 7, but since the composer.json user an unbounded version constraint for Guzzle it just installs without errors... Using this package in a project with Guzzle 7 will break it, example exception:

Class 'GuzzleHttp\UriTemplate' not found

vendor/slimpay/hapiclient/src/Http/HapiClient.php
:224

Anyway I think expecting a response here is wishful thinking since the only other issues is from 2018 and has no responses.

So my main question: anyone here?

@marijnhurkens
Copy link
Author

So we contacted support on december 8th 2020, they have been working on it since then. But this is a blocking issue for us since we are using Laravel 7 right now.

I made a pr (#16 ), maybe this helps @SlimPayDev ?

@xelab
Copy link

xelab commented Jan 20, 2021

Hello,

Same here and we need a fix too, Guzzle is used in many applications.

@SlimPay
Copy link
Owner

SlimPay commented Feb 3, 2021

Hello, sorry for the delay.

So we released a new version in another repository in order to not accumulate "if Guzzle7 / elseif Guzzle 6 / else" instruction and to not break clients implementations.

So you can find this at https://packagist.org/packages/slimpay/hapiclient-guzzle7 or https://github.com/SlimPay/hapiclient-php-guzzle7

@marijnhurkens thank you for your help with your MR. We would like to add you in our README in a Contributor part, are you ok with this? And if yes, do you want to add a link to your website or anything else?

@marijnhurkens
Copy link
Author

Hi, nah just a mention is fine. Thanks for picking this up :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants