Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Velocity build 3.3 Brand Changer Support #96

Open
R00tB33rMan opened this issue Jan 13, 2024 · 3 comments
Open

Velocity build 3.3 Brand Changer Support #96

R00tB33rMan opened this issue Jan 13, 2024 · 3 comments
Assignees
Labels
feature New feature or request

Comments

@R00tB33rMan
Copy link

As of this commit, Velocity support breaks in conjunction with the brand feature in Leaf. Here's the log: https://pastebin.com/bGkhpCRp

@R00tB33rMan R00tB33rMan added the feature New feature or request label Jan 13, 2024
@JosTheDude
Copy link

JosTheDude commented Jan 16, 2024

If you're looking for support on velocity builds 320+, you can check here:

https://github.com/JosTheDude/leaf/releases

The fork was made with Velocity 3.3.0 Build 320+ support in mind; so the file size is much larger due to netty and fastutil having to be compile scoped.

Not compatible with Velocity versions under build 3.3.0-320, hence the separate repository

@R00tB33rMan
Copy link
Author

New issue appears as of build 329+, which makes these changes.

Essentially, this update changes various variable names and nothing more. Assuming all this requires is a few modifications.

@Smudgge
Copy link
Owner

Smudgge commented Jun 7, 2024

I've removed the brand changer from working when the velocity version is 3.0 for now.

@Smudgge Smudgge changed the title Velocity build 320+ support Velocity build 3.2+ Brand Changer Support Jun 7, 2024
@Smudgge Smudgge changed the title Velocity build 3.2+ Brand Changer Support Velocity build 3.3 Brand Changer Support Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
Status: Todo
Development

No branches or pull requests

3 participants