Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue]: App creates duplicate profiles during login when there are duplicate phone numbers #49

Open
1 of 2 tasks
bobrufenacht opened this issue Dec 19, 2024 · 2 comments
Labels
bug Something isn't working unverified This issue has not been verified yet

Comments

@bobrufenacht
Copy link

Describe the Issue in Detail

(On behalf of Church of the King) If two people have the same phone number, a duplicate person/profile is created every time the person logs in to the App. This is true even if only one person has it as their mobile phone. Every time those people logout and back in they get a new profile and their old profile information is missing until the profiles are merged. This is very confusing for the App users and manifests itself in statements of "my data is gone."

While cleaning duplicates can help, duplicate phone numbers are consistently added to the system through a variety of forms and registrations, especially since the App is not distinguishing Mobile numbers from other numbers in the comparison.

Can reproduce in

  • Orange App
  • Blue App

Steps to Reproduce

  1. Create a person and login from the App. If it's a new person they won't have rights or protection levels that require duplicates.
  2. Add a child to the same family and add the original person's mobile number as the child's home number.
  3. Logout of the App
  4. Re-login
  5. You will be prompted for all information again and a new profile will be created.

Expected Behavior

I would expect one of three behaviors:

  1. It could behave like passwordless login and prompt for which person it is. The issue I see here is that it would do that every time the person logs out and back in.
  2. It could use the information provided and not just the phone number to match to a person. The first and last name are prompted for first. If they form a unique match with first/last/mobile, accept that and don't prompt further. If not unique, prompt and retry the match adding birthdate and email.
  3. It could use a "User Account" method like external logins where it links the App to the User with a unique identifier. As long as the App is not uninstalled, it knows the person once the phone number is validated (like an App_########## type account name).

I would expect that if I logout and log back in it would not create a duplicate and not require a protracted login on the App.

Actual Behavior

Every time people with duplicate phone numbers in rock login through the App a duplicate is created and must be merged. The person's data (giving registrations, other features) is gone until the merge is completed.

Screenshots or Videos

Nothing special to show. All normal screens it just creates duplicates.

Reproduction XAML

No response

Mobile Shell Version

V7

Last Known Working Version

No response

iOS Device Type(s) and iOS Version(s)

iPhone 15 Pro iOS 18.11

Android Device Type(s) and Android Version(s)

Verified by another person to happen but not sure of the versions

@bobrufenacht bobrufenacht added bug Something isn't working unverified This issue has not been verified yet labels Dec 19, 2024
@Tibincrunch
Copy link

Hey there @bobrufenacht! Out of the box, Rock will only perform a duplicate check on accounts with a Low protection profile:
https://community.rockrms.com/Rock/BookContent/9#securitysettings

If the duplicate check is disabled, a new account will always be created for safety.

Each Rock instance can configure these security settings to fit their needs best. Can you confirm if the affected accounts in your report are included in the Disable Duplicate Checking for the Following Protection Profiles security setting? Just wanted to rule that out before investigating further. Thanks!

@bobrufenacht
Copy link
Author

Hi @Tibincrunch. I've confirmed this bug on two system, one with High and Extreme disabled and one with only Extreme disabled. In my testing, I was working with "new" test people I added who would have been "Low" by default as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working unverified This issue has not been verified yet
Projects
None yet
Development

No branches or pull requests

2 participants