Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WSGI ignore for specific user agent #30

Open
nils-van-zuijlen opened this issue Feb 20, 2023 · 3 comments
Open

Add WSGI ignore for specific user agent #30

nils-van-zuijlen opened this issue Feb 20, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@nils-van-zuijlen
Copy link

Is your feature request related to a problem? Please describe.

Kubernetes has a liveness and a readiness probe that can be configured to use HTTP.
All of these requests use the kube-probe/<version> user agent.

Describe the solution you'd like

I would like to be able to exclude all requests with the kube-probe user agent, and other specific user agents if needed (the go module mirror comes to my mind)

Describe alternatives you've considered

Entering manually every probing endpoint in the WSGI ignore path, but that does not allow to have a default value that excludes automatically all kube-probe endpoints.

@Kl0ven Kl0ven added the enhancement New feature or request label Feb 20, 2023
@Kl0ven
Copy link
Contributor

Kl0ven commented Feb 20, 2023

Having a user agent filter would be nice, but i avoided using regex filter to prevent slowdown.
It's the same problem: how to handle the version ?

We could also do a kube-probe specialized filter.

@nils-van-zuijlen
Copy link
Author

I think an implementation could be excluded_agent in user_agent or user_agent.startswith(excluded_agent).
Or even excluded_agent == user_agent because the version does not change that often.

@Kl0ven
Copy link
Contributor

Kl0ven commented May 30, 2023

Release in latest alpha version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants