Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The error notifications are not working #5

Open
Commifreak opened this issue Sep 7, 2022 · 2 comments
Open

The error notifications are not working #5

Commifreak opened this issue Sep 7, 2022 · 2 comments

Comments

@Commifreak
Copy link

While creating the PR #4 I noticed, that the verify success check is not working. Since the command is like:

cd '/mnt/user/appdata/' && /usr/bin/tar --diff -C '/mnt/user/appdata/' -af '/mnt/disks/92E6P00LT/appdata/[email protected]/CA_backup.tar' >> /var/lib/docker/unraid/ca.backup2.datastore/appdata_backup.log 2>&1 & echo $! > /tmp/ca.backup2/tempFiles/verifyInProgress

and the script checks THAT returncode, it is always 0, because the stored returncode is the one of the echo $!. The tar error is never captured - but its there!

[07.09.2022 09:40:57] Verifying Backup
[07.09.2022 09:40:57] Using command: cd '/mnt/user/appdata/' && /usr/bin/tar --diff -C '/mnt/user/appdata/' -af '/mnt/disks/92E6P00LT/appdata/[email protected]/CA_backup.tar' >> /var/lib/docker/unraid/ca.backup2.datastore/appdata_backup.log 2>&1 & echo $! > /tmp/ca.backup2/tempFiles/verifyInProgress
/usr/bin/tar: This does not look like a tar archive
/usr/bin/tar: Exiting with failure status due to previous errors
[07.09.2022 09:40:57] Starting xxx
[07.09.2022 09:40:59] Backup/Restore Complete.  tar Return Value: 0

I still try to solve this as well (I create another PR if I find a quick solution) and wanted to note that here already.

The solution to this one also should check the initial tar creation success

Commifreak pushed a commit to Commifreak/ca.backup2 that referenced this issue Sep 7, 2022
@Commifreak Commifreak changed the title The error notifications is not working The error notifications are not working Sep 7, 2022
@Commifreak
Copy link
Author

Found a solution - tested all cases - works fine now.

@Commifreak
Copy link
Author

Anything new on this? In my eyes the check is currently broken and not reliable without #6 . If not, please tell me :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant