Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skipped Tests: Chronology #35

Closed
duncdrum opened this issue Jan 16, 2024 · 6 comments
Closed

skipped Tests: Chronology #35

duncdrum opened this issue Jan 16, 2024 · 6 comments
Assignees
Labels
bug Something isn't working

Comments

@duncdrum
Copy link
Member

Andreas Gryphus has many relevant 21st century publication, but the top 20 is 17 of 20 before 1985

@duncdrum duncdrum added the bug Something isn't working label Jan 16, 2024
duncdrum added a commit that referenced this issue Jan 16, 2024
some caveats about dates displayed in resultlist-data

see #11 #35 #36
duncdrum added a commit that referenced this issue Jan 19, 2024
some caveats about dates displayed in resultlist-data

see #11 #35 #36
duncdrum added a commit that referenced this issue Jan 19, 2024
@duncdrum duncdrum self-assigned this Feb 5, 2024
duncdrum added a commit that referenced this issue Feb 5, 2024
@annekauf
Copy link
Collaborator

annekauf commented Feb 6, 2024

not able to find relevant publications with publication date after 2020 - which is the test assertion (1st hit published after 2020). I'd like to adapt the test assertion.

@duncdrum
Copy link
Member Author

duncdrum commented Feb 6, 2024

Using chronological sorting in an allFields or Titel seach I see (random selection):

I m therefore hesitant to change the test assertion, from what i can see these hits should appear in the TOP 20. How could a volume from the 70s or 80s be that much more relevant just based on the ranking config, and without taking something like citation index into account?

@annekauf
Copy link
Collaborator

annekauf commented Feb 6, 2024

About half of those examples are published in 2020. Could test be amended to "1st hit should be published after 2019"? - Have just seen the exact code: .contains(/202\d/). This means first hit could be published IN 2020, right? Then test doesn't need to be changed.

@annekauf
Copy link
Collaborator

annekauf commented Feb 6, 2024

Chronology test - therefore test assertion "should contain both primary and secondary literature" for search terms "jugendliteratur mittelalter roman" doesn't compute. Or put it this way: this assertion hasn't been put as a ranking goal. Tbd.

@annekauf
Copy link
Collaborator

annekauf commented Feb 6, 2024

Similar: assertion "should show relevant titles in translation" for search all fields "griechische mythologie". Tbd, please. :)

@duncdrum
Copy link
Member Author

duncdrum commented Feb 6, 2024

.contains(/202\d/) means 202[0-9] any digit will work

duncdrum added a commit that referenced this issue Feb 7, 2024
annekauf pushed a commit that referenced this issue Feb 8, 2024
duncdrum added a commit that referenced this issue Feb 12, 2024
use string based boost function

close #35
see #11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants