Recommend using <Set|Add>LoadFields

[someC0d3r]

Currently the CodeCop warns you if you use a field which is not loaded in the current scope, but this warning only occurs if you have SetLoadFields in your code scope - if you don't have it in the scope, the warning doesn't show up / it doesn't get checked

Hint: If you change SetLoadFields with AddLoadFields the warning also doesn't show up - so the trigger seems to be SetLoadFields for this CodeCop rule

The idea:

1. Create a new rule which recommends you using SetLoadFields if you use for example <Record|RecordRef>.Find, FindSet, FindFirst, FindLast, Next (maybe more) and a field of it
2. This rule should also work if you pass the record/recordref variable to a procedure (AA0242 doesn't check this unfortunately :( )

Example for 2.:

It doesn't give you the warning in the method :/

Reason:
To make the performance of your solution / app better by using <Set|Add>LoadFields this rule would be a big help.

Greets
someC0d3r :)

[StefanMaron]

Yeah, I thought a lot about a rule like this recently. But it gets more complicated the longer you think about it.

the rule should then also be able to trace variables if they are passed by reference, that only works until the call path leaves the current extension.
I am not even sure how that would be possible in the analyzer

[someC0d3r]

Yea... the struggle about tracing the variables came in my mind too.
Variable "SalesCommentLine" -> SomeFunction(SalesCommentLine) -> SomeFunction2(SalesCommentLine) - and so on..

If this rule will get implemented it will be a bit "hackish" I suppose :/

[fvet]

Also some other restrictions apply if the Findx would be followed by a Modify, ...:

For performance reasons, it's not recommended to use partial records on a record that will do inserts, deletes, renames, field transfers, or copies to temporary records. All these operations require that all fields on the record are loaded, so the platform will emit a JIT load if they're not already loaded.

[fvet]

Maybe we should start 'small' first and limit the scope of the warning to below usages?

• Focus on 'local' record variables only
• Record variable should be subject of a 'find' procedure (findfirst, findset, findlast ...) (no isempty) -> read
• Record variable should not have any function call (no Insert, Modify, Delete, Modifyall, deleteall, ... nor any procedure on the table itself) -> no involved in any updates
• Record variable should not be used as argument in any function calls -> no references
• Record variable should not be used as argument in any event publishers -> no references

This would at least show the occurrences where a record is fetched to only read data / get a field value.

https://www.yammer.com/dynamicsnavdev/#/Threads/show?threadId=1033577983172608