Some warnings against enums

[janvtBE]

Next piece of code is a bit strange concerning creating an enum:

enum 58100 "VRA Test Enum VRA"
{
    Extensible = true;
    Caption = 'Test Enum';

    value(0; "")
    {
        Caption = 'Empty';
    }
    value(1; "Not Processed")
    {
        Caption = '';
    }
    value(2; "Processing")
    {
        Caption = 'Processing';
    }
    value(3; "Processed")
    {
        Caption = 'Processed';
    }
    value(4; "Error")
    {
        Caption = 'Error';
    }
}

An enum with empty name and a caption filled in, like value 0: this is strange, because you cannot select this in de GUI and you cannot use this in AL Code.

An enum with the name filled in and an empty caption, like value 1: this is also strange, this is not selectable in the GUI, allthough you can handle this in AL Code.

So in case of enum 0 and 1, a warning can be helpful to get your focus on this.

Looking forward to your opinion.

[rvanbekkum]

The second example is something we do intentionally, but typically with value 0, e.g.:

value(0; Undefined)
{
    Caption = '', Locked = true;
}

BUT in combination with , Locked = true.

Maybe, we could have a warning when , Locked = true is missing, because otherwise you can have really weird stuff happening (when in some translations the caption is non-empty, while in others it is empty).

[janvtBE]

Isn't this solved with implementation of rule LC0041? https://github.com/StefanMaron/BusinessCentral.LinterCop/wiki/LC0041

[rvanbekkum]

I guess so. It clashes with LC0045 though, so that's why we have disabled that rule.
See: #486

[Arthurvdv]

@janvtBE, thank you for the suggestion and @rvanbekkum for the additional input on this!

There two new rules in the (pre)release version of v0.30.16 of the LinterCop

• LC0056: Empty Enum values should not have a specified Caption property.
• LC0057: Enum values must have non-empty a Caption to be selectable in the client.

[janvtBE]

Thanks @Arthurvdv !