From c44c3d46a64f72f6939afb9846c1c3ed71f092a5 Mon Sep 17 00:00:00 2001 From: Katherine Whitlock Date: Tue, 11 Feb 2025 23:39:14 -0500 Subject: [PATCH] Revert "Remoove deadBEEF" This reverts commit 5879265a8ca4a1f92ac2c6d7c399221c8e6677f8. --- src/deluge/processing/sound/sound.h | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/src/deluge/processing/sound/sound.h b/src/deluge/processing/sound/sound.h index 7d1189f3aa..5a017cdbad 100644 --- a/src/deluge/processing/sound/sound.h +++ b/src/deluge/processing/sound/sound.h @@ -88,6 +88,23 @@ class Sound : public ModControllableAudio { LFO globalLFO3; LFOConfig lfoConfig[LFO_COUNT]; + // December 3, 2024 + // @todo + // Commit 6534979986d465a0acf01018e066e1d7ca1d170e + // From PR #2004 (LFO: cleanups in preparation for LFO2 sync support) + // (https://github.com/SynthstromAudible/DelugeFirmware/pull/2004) + // Removed four uint8_t lfo variables from this section and replaced them with the LFOConfig + // definition above. This unknowingly introduced a "release" bug which changed the sound of the + // Deluge synth engine compared to 1.1 as reported in issue #2660: + // (https://github.com/SynthstromAudible/DelugeFirmware/issues/2660) + // As a TEMPORARY solution, padding is being added here to fix the bug so as to not hold up + // the 1.2 Beta release. + // Emphasis on temporary as this bug needs a proper fix, otherwise it will keep coming back + // as changes get made to this Sound class. + // We think the issue relates to the use of "offsetof" in the param and patcher system + // (related to the paramFinalValues / globalSourceValues definitions above) + uint32_t temporaryPadding{0xDEADBEEF}; + ModKnob modKnobs[kNumModButtons][kNumPhysicalModKnobs]; int32_t sideChainSendLevel;