-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix-update MNX IDs according to MNX database latest release 4.0 #245
Comments
@Hao-Chalmers @edkerk, What about also updating MNX database info stored in RAVEN toolbox, since in some function, we relies on |
@feiranl good idea in providing different MNX versions in |
These IDs should indeed be updated in yeast-GEM, and the relevant file should also be updated in RAVEN. What would be the benefit of supporting older MNX versions? I would not be recommended to use deprecated identifiers, and if a user would really want to do that, they can always pull an earlier commit / download an earlier release. So I suggest we only distribute and support the latest version. |
This update of MNX(4.0) updated so many IDs(including many basic chemicals such as water O2 and NH4+), if we only keep the latest 4.0 version, which may cause the function not working for every old models contain older version MNX IDs |
If it is useful, once i finished working around #378 It's very easy for me to spit out a list of metabolite ids and matching metanetx 4.4 ids. |
Description of the issue:
MetaNetX IDs in the model should be renewed based on the latest version 4.0 of MNX database, in this update, many MNX IDs are deprecated. Meanwhile MNX has updated the yeast model to yeast8.3.4 in their website, which reduced our work. We can update MNX IDs for both mets and rxns based on the info yeast8.3.4.
Here is one example:
MNX IDs are not longer existing:
MNXR125024
forr_0465
, should be replaced byMNXR153706
MNX met IDs are no longer existing:
MNXM162238
foralpha-D-glucosamine 6-phosphate [cytoplasm]
, should be replaced byMNXM730219
MNX IDs for
NH4+
,water
,O2
are also deprecated.I hereby confirm that I have:
master
branch of the repositoryThe text was updated successfully, but these errors were encountered: