Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C# parser cannot handle identifiers named async #65

Open
joefeser opened this issue Aug 10, 2024 · 3 comments
Open

C# parser cannot handle identifiers named async #65

joefeser opened this issue Aug 10, 2024 · 3 comments
Labels
bug Something isn't working github This issue is about our GitHub App

Comments

@joefeser
Copy link

Describe the Bug
There is a parsing error for a few files that are just function declarations.

To Reproduce
Steps to reproduce the behavior:

  1. Select the File

Expected Behavior
No Parsing Error

Link
https://app.semanticdiff.com/gh/joefeser/opensearch-net/pull/3/changes#src/ApiGenerator/Domain/Code/HighLevel/Methods/FluentSyntaxView.cs?ignore_comments=true

https://app.semanticdiff.com/gh/joefeser/opensearch-net/pull/3/changes#src/ApiGenerator/Domain/Code/HighLevel/Methods/InitializerSyntaxView.cs?ignore_comments=true

image

image

@joefeser joefeser added bug Something isn't working github This issue is about our GitHub App labels Aug 10, 2024
@mmueller2012
Copy link
Contributor

Thanks for reporting this bug.

The issue is actually unrelated to the arrow style function declaration, but has to do with the async parameter. The async in (syntax, async) is parsed as a keyword instead of an identifier, leading to the parsing error.

We will try to fix this in an upcoming update.

@mmueller2012 mmueller2012 changed the title Arrow function parsing error C# parser cannot handle identifiers named async Aug 12, 2024
@mmueller2012
Copy link
Contributor

The issue has been fixed for our GitHub App by switching the C# parser as explained in #66.

I will close the issue once the new parser has also been shipped as part of our VS Code extension.

@joefeser
Copy link
Author

joefeser commented Sep 3, 2024

Thank you. I will wait for the new version and give it a try. I perform my PR's in VS Code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working github This issue is about our GitHub App
Projects
None yet
Development

No branches or pull requests

2 participants