Removed administrator role change permission #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wwelling
reviewed
Jan 13, 2025
| @@ -59,9 +59,6 @@ public class WebSecurityConfig { | |||
| @Value("${spring.h2.console.enabled:false}") | |||
| private boolean h2ConsoleEnabled; | |||
|
|
|||
| @Value("${server.servlet.session.cookie.domain:library.tamu.edu}") | |||
| private String domainName; | |||
There was a problem hiding this comment.
Please restore and override in properties for development.
There was a problem hiding this comment.
Changes made, please review and verify.
wwelling
reviewed
Jan 13, 2025
| @@ -151,8 +148,6 @@ public CookieSerializer cookieSerializer() { | |||
| serializer.setUseSecureCookie(false); | |||
| serializer.setCookiePath("/"); | |||
| serializer.setCookieName("SESSION"); | |||
| serializer.setDomainName(domainName); | |||
There was a problem hiding this comment.
Please restore and override in properties for development.
There was a problem hiding this comment.
Changes made, please review and verify.
kaladay
requested changes
Jan 14, 2025
kaladay
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #452
Removed ability for
administratorsto modify a given users role.