Using JS resizeTo directly on renderer #1136
Open
+141
−102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think there might be a conflict with #1134 |
araujoarthur0
force-pushed
the
resize-window
branch
2 times, most recently
from
7db7765 to
224293b
Compare
araujoarthur0
force-pushed
the
resize-window
branch
2 times, most recently
from
3f816cf to
38dc66c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
|
araujoarthur0
force-pushed
the
resize-window
branch
from
38dc66c to
2400647
Compare
araujoarthur0
force-pushed
the
resize-window
branch
from
dcbc9f4 to
587d66c
Compare
araujoarthur0
force-pushed
the
resize-window
branch
from
587d66c to
6305aa4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
Closes #1135
Context / Background
We currently resize the calendar upon changing from month/day view by calling back to main and asking it to resize the browser window.
We can however just use javascript's resizeTo directly from renderer.
What change is being introduced by this PR?
Replacing the use of the ipc event with javascript's resizeTo.
Modifying getDefaultWidthHeight to receive a preferences parameter.
Changing the calendar view is actually faster now.
How will this be tested?
Ran locally, tests updated.