bump timeout by one second for windows tests #1159
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ |
|
I'm confused, as the screenshot in the issue you opened shows that what is failing is |
|
The timeout is the reason it fails. |
| @@ -202,7 +202,7 @@ describe('Test Workday Waiver Window', function() | |||
| beforeEach(async() => | |||
| { | |||
| await prepareMockup(); | |||
| }); | |||
| }).timeout(3000); | |||
There was a problem hiding this comment.
Can you add a comment explaining the reason behind the added timeout?
And was the beforeEach() the reason and not really a test?
I understand the timeout is the reason, but it is a timeout on |
|
I'm closing this for two reasons, but mainly because I'm not certain why that particular test is the one that made it stop happening and it makes a lot more sense to just run the windows tests with a raised timeout from the script. |
Related issue
Closes #1158
Context / Background
Currently the Windows mocha tests will fail sometimes, due to a timeout.
What change is being introduced by this PR?
I changed the timeout for that portion from 2 seconds to 3. It doesn't take 3 seconds, but it does take more than 2 in some cases.
How will this be tested?
Applying this PR to a timeout failing branch it should fix that.
Screenshots
Before:
After:
