-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Accent Colors show as Gray on Windows with PySide 6.8.0.1 #668
Comments
id be happy to fix this |
Hi, wanted to check this out noticed the accent color is totally different from the one shown above 😅. commenting out the following snippet gave me shown the color scheme. pal: QPalette = app.palette()
pal.setColor(QPalette.ColorGroup.Active,
QPalette.ColorRole.Highlight, QColor('#6E4BCE'))
pal.setColor(QPalette.ColorGroup.Normal,
QPalette.ColorRole.Window, QColor('#110F1B'))
app.setPalette(pal) In self.hover_color: QColor = QPalette.color(
self.palette(),
QPalette.ColorGroup.Active,
QPalette.ColorRole.Accent,
) got it working by adding the following line @CyanVoxel and doing slight adjustment mentioned in #672 pal: QPalette = app.palette()
pal.setColor(QPalette.ColorGroup.Active,
QPalette.ColorRole.Highlight, QColor('#6E4BCE'))
+ pal.setColor(QPalette.ColorGroup.Active,
+ QPalette.ColorRole.Accent, QColor('#6E4BCE'))
pal.setColor(QPalette.ColorGroup.Normal,
QPalette.ColorRole.Window, QColor('#110F1B')) without the adjustment (left is before and right is after) : after the adjustment mentioned in the PR #672 self.hover_color.setHsl(
self.hover_color.hslHue(),
self.hover_color.hslSaturation(),
- min(self.hover_color.lightness() + 80, 255),
+ min(self.hover_color.lightness() + 80, 200),
self.hover_color.alpha(),
) TagStudio Version
Operating System
let me know if it works ! 👋🏽 |
The color in the screenshot from aaea0b1 is derived from my system accent color, which is why yours is different and implies that the feature is working as intended
I'm a bit confused why you mention the code here, as its unrelated to the issue at hand and hasn't been active in the program for at least 9 months: d974aa7.
Yes,
Unfortunately the old behavior (aaea0b1) up until this bug was to use the user's system accent color, not to use hardcoded values which is what that (very old) commented-out code did and what this solution suggests. This bug is also affecting the main branch, not the
|
oww okay got it ! thank you for the explanation. let me look more into this; |
Checklist
TagStudio Version
main
branch (v9.5.0)Operating System & Version
Windows 10 22H2
Description
System accent colors grabbed by QPalette show as gray on Windows as of updating to PySide 6.8.0.1. The following snippet is from
thumb_button.py
:PySide 6.7.1 (aaea0b1)
PySide 6.8.0.1 (latest)
Note that I've only seen this occur on Windows while it seems to be functioning on macOS. Other native Qt widgets such as loading bars also seem to be grabbing the accent color correctly.
Expected Behavior
Accent/selection colors on all platforms should function as they used to before PySide 6.8.0.1.
Steps to Reproduce
Logs
No response
The text was updated successfully, but these errors were encountered: