Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spotlight position between phones #61

Closed
krisdb opened this issue Feb 15, 2019 · 5 comments
Closed

Spotlight position between phones #61

krisdb opened this issue Feb 15, 2019 · 5 comments
Labels

Comments

@krisdb
Copy link

krisdb commented Feb 15, 2019

The spotlight position is different between two phone. A Pixel 2 XL emulator looks like this:

https://i.imgur.com/G7Lcrmq.png

but on a Pixel 3 XL phone (no emulator) it's here:

https://i.imgur.com/7qddSSE.png

I'm thinking the notch might be effecting the positioning.

I'm also using 1.5.0 because 1.8.0 is throwing some manifest merge compiling error.

@ghataa
Copy link
Contributor

ghataa commented Mar 13, 2019

Same here with positioning!

@TakuSemba
Copy link
Owner

I'm also using 1.5.0 because 1.8.0 is throwing some manifest merge compiling error.

take a look at this issue #63

@TakuSemba
Copy link
Owner

TakuSemba commented Sep 3, 2020

The spotlight position is different between two phone.

I tested on Pixel 3 XL but could not reproduce it on the demo app.
Can you reproduce it on the demo app and share the branch so that I can look into it?

@TakuSemba TakuSemba added the bug label Sep 3, 2020
@TakuSemba
Copy link
Owner

I think this happens when you use both setAnchor(view) and setContainer() and the anchor does not take the container position into consideration.

I believe I fixed it on v2.0.2.
Please reopen this, if it still happens.

@lrnrzg
Copy link

lrnrzg commented Dec 3, 2022

the solustion can produce new bug when you setAnchor(x,y) and set Container whose coordinate is not (0,0) on screen, I fix it by create the pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants