Options to set a commandPrefix in addCommands() #240
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
NB: Travis fails because of incompatibility of |
|
@TalAter Any thoughts on this ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added possibility to set a commandPrefix in a
Ok google [...]fashionMotivation and Context
The change allow to filter out a lot of noise by only triggering when the prefix is spoken.
Fixes #18
How Has This Been Tested?
Tested the match with pref and the no-match without the prefix
Tests : cd1f756#diff-e504a2e67b28d9ebc5fac06973ab8275R487
recognition.onresult will not add any commandPrefix
Types of changes
Checklist: