Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translatable permissions buttons #62

Open
aexvir opened this issue Jan 4, 2017 · 7 comments
Open

Translatable permissions buttons #62

aexvir opened this issue Jan 4, 2017 · 7 comments
Assignees
@bezmian
Milestone
0.0.6

Comments

@aexvir
Copy link

aexvir commented Jan 4, 2017

Could this option be added? It's strange to have the whole application in one language and the buttons always in english.

Maybe the translation string could be passed as a second option to the neededPermissions and possiblePermissions methods.

Many thanks!
@bezmian
Copy link
Contributor

bezmian commented Jan 4, 2017

Good idea, we'll add that to todo list. ;)

@aexvir
Copy link
Author

aexvir commented Jan 5, 2017

@bezmian Thanks! :)

@volvciklum
Copy link

We also need this feature. Please try to include it into the next release. Thanks.

@xp-vit
Copy link

xp-vit commented Jan 24, 2017

Also faced this one. Would love it to be added.

@radzio radzio added this to the 0.0.6 milestone Jan 26, 2017
@radzio radzio assigned radzio and bezmian and unassigned radzio Jan 31, 2017
@radzio
Copy link
Contributor

radzio commented Feb 2, 2017 •
edited
Loading

@proudh0n @volvciklum @xp-vit

For now you can simply override grant_permissions ( mis_grant_permissions in the upcoming 0.0.6 version). But we can't guarantee that we will not change this string resource name in future it is not recommended solution.

However, in next 0.0.6 we will provide:

  • possibility to set default permission button text ( @StringRes ) on MaterialIntroActivity
  • possibility to override default permission button text on each slide ( @StringRes ) using SlideFragmentBuilder
  • library by default will use grant_permissions ( mis_grant_permissions since 0.0.6 version) string resource

@proudh0n @volvciklum @xp-vit it would be great if you could add translations for default grant_permissions text in your languages and create some PRs ;). It will be much easier for other library users if it will have default translations out of the box ;)

So guys what do you think about it?

Cheers!

@aexvir
Copy link
Author

aexvir commented Feb 8, 2017

@radzio Of course, I'll translate the strings as soon as possible. Many thanks for implementing the feature

bezmian added a commit that referenced this issue Apr 3, 2017
@bezmian
#62 Add translatable permissions strings for Slides
b6e9565 
 * Update README.md
 * Add example to app module
@volvciklum
Copy link

Could this issue be merged/closed during next 1-2 weeks? Any chance?

bezmian added a commit that referenced this issue Sep 21, 2017
@bezmian
Merge pull request #98 from TangoAgency/feature/custom_permission_string
e510ea9 
#62 Add translatable permissions strings for Slides
bliveinhack added a commit to bliveinhack/material-intro-screen that referenced this issue Dec 6, 2017
@bliveinhack
Squashed commit of the following:
9a38561 
commit a284407
Merge: 33b0c4e 6cae917
Author: Filip Skowron <[email protected]>
Date:   Thu Sep 21 12:51:46 2017 +0200

    Merge pull request TangoAgency#97 from TangoAgency/feature/set_message_btn_text

    TangoAgency#91 Add MessageButtonClickListener

commit 6cae917
Author: bezmian <[email protected]>
Date:   Thu Sep 21 12:45:51 2017 +0200

    TangoAgency#91 Fix issue with non working MessageButtonBehaviour in example IntroActivity

commit ab5745a
Merge: 3fd86e3 33b0c4e
Author: bezmian <[email protected]>
Date:   Thu Sep 21 12:42:36 2017 +0200

    Merge remote-tracking branch 'origin/release/0.0.6' into feature/set_message_btn_text

    # Conflicts:
    #	README.md
    #	app/src/main/java/agency/tango/materialintro/IntroActivity.java
    #	build.gradle
    #	gradle/wrapper/gradle-wrapper.properties
    #	versions.gradle

commit 33b0c4e
Merge: a3245c0 b92da12
Author: Filip Skowron <[email protected]>
Date:   Thu Sep 21 12:39:52 2017 +0200

    Merge pull request TangoAgency#87 from TangoAgency/feature/update_lint

    Update Android Support Repository versions

commit b92da12
Author: bezmian <[email protected]>
Date:   Thu Sep 21 12:29:14 2017 +0200

    TangoAgency#87 Second attempt to fix travis builds

commit b915682
Author: bezmian <[email protected]>
Date:   Thu Sep 21 12:24:46 2017 +0200

    TangoAgency#87 Attempt to fix travis builds

commit c320585
Author: bezmian <[email protected]>
Date:   Thu Sep 21 12:19:50 2017 +0200

    TangoAgency#87 Update Android support libraries to 26.1.0

commit 67316a4
Merge: b63f8dc a3245c0
Author: bezmian <[email protected]>
Date:   Thu Sep 21 11:55:29 2017 +0200

    Merge remote-tracking branch 'origin/release/0.0.6' into feature/update_lint

    # Conflicts:
    #	gradle/wrapper/gradle-wrapper.properties

commit a3245c0
Merge: e510ea9 c8cbb54
Author: Filip Skowron <[email protected]>
Date:   Thu Sep 21 11:53:40 2017 +0200

    Merge pull request TangoAgency#78 from TangoAgency/feature/permissions_android_lollipop

    Permissions in Android Lollipop

commit e510ea9
Merge: db289f7 b6e9565
Author: Filip Skowron <[email protected]>
Date:   Thu Sep 21 11:14:17 2017 +0200

    Merge pull request TangoAgency#98 from TangoAgency/feature/custom_permission_string

    TangoAgency#62 Add translatable permissions strings for Slides

commit b6e9565
Author: bezmian <[email protected]>
Date:   Mon Apr 3 14:40:18 2017 +0200

    TangoAgency#62 Add translatable permissions strings for Slides
     * Update README.md
     * Add example to app module

commit b63f8dc
Author: bezmian <[email protected]>
Date:   Mon Apr 3 11:22:03 2017 +0200

    Update AndroidSupportLibrary version
     * Fix style bug on Android < v21

commit 3fd86e3
Author: bezmian <[email protected]>
Date:   Thu Mar 30 11:56:45 2017 +0200

    TangoAgency#91 Add MessageButtonClickListener
     * Update Readme
     * Update gradle
     * Update AndroidSupportRepository version

commit 4dda9b9
Author: bezmian <[email protected]>
Date:   Fri Mar 3 14:06:04 2017 +0100

    Update Android Support Repository versions
     * Update gradle build tools to 2.3
     * Fix Lint errors in App module

commit c8cbb54
Author: bezmian <[email protected]>
Date:   Mon Feb 20 14:04:48 2017 +0100

    Remove unnecessary methods from CustomSlide
     * Use Android TextUtils

commit db289f7
Author: Filip Skowron <[email protected]>
Date:   Mon Feb 20 11:29:34 2017 +0100

    Add showing error on failed swipe (TangoAgency#77)

    * Add ISlideErrorHandler
     * Better code formatting

commit 253c7c8
Author: Filip Skowron <[email protected]>
Date:   Mon Feb 20 11:22:32 2017 +0100

    Update Support Libraries to 25.1.1 (TangoAgency#80)

    * Add ParallaxPercentFrameLayout
     * Add ParallaxPercentRelativeLayout

commit 758608b
Merge: cdfb1bf b22bf75
Author: bezmian <[email protected]>
Date:   Mon Feb 20 10:45:53 2017 +0100

    Merge remote-tracking branch 'origin/release/0.0.6' into feature/permissions_android_lollipop

    # Conflicts:
    #	README.md
    #	material-intro-screen/src/main/java/agency/tango/materialintroscreen/fragments/SlideFragmentBase.java

commit b22bf75
Author: Filip Skowron <[email protected]>
Date:   Mon Feb 20 10:29:53 2017 +0100

    Add Jacoco support (TangoAgency#83)

    * buildToolsVersion set to 25.0.2

commit 69a806f
Author: Filip Skowron <[email protected]>
Date:   Mon Feb 20 10:29:20 2017 +0100

    Add base slide fragment class (TangoAgency#75)

    * SlideFragmentBuilder now throws Exception when missing necessary properties

    * Fix Codacy issues
     * Better class fields managment
     * Better packages naming

    * Fix Codacy issues
     * Suppress warnings in classes from other open source projects
     * Suppress warnings for nested condition statements for better readability

    * Move permissions handling to SlideFragmentBase
     * SlidesAdapter now stores SlideFragmentBase
     * Migrate every method from SlideFragment to SlideFragmentBase

    * Create behaviours and fragments package
     * Move proper classes to packages
     * Optimize imports

    * Make SlideFragmentBase methods not abstract
     * Update Readme
     * Update CustomSlide example
     * Add default slide colors

commit cdfb1bf
Author: bezmian <[email protected]>
Date:   Fri Feb 10 16:42:08 2017 +0100

    Fix showing permissions button in Android Lollipop and versions below.

commit 57886a4
Author: bezmian <[email protected]>
Date:   Fri Feb 10 13:30:25 2017 +0100

    Create behaviours and fragments package
     * Move proper classes to packages
     * Optimize imports

commit 3d1d1fe
Author: bezmian <[email protected]>
Date:   Wed Feb 8 12:56:32 2017 +0100

    Move permissions handling to SlideFragmentBase
     * SlidesAdapter now stores SlideFragmentBase
     * Migrate every method from SlideFragment to SlideFragmentBase

commit ede70c4
Author: bezmian <[email protected]>
Date:   Fri Feb 3 16:28:55 2017 +0100

    Fix Codacy issues
     * Suppress warnings in classes from other open source projects
     * Suppress warnings for nested condition statements for better readability

commit 0b17c6a
Author: bezmian <[email protected]>
Date:   Fri Feb 3 16:04:20 2017 +0100

    Fix Codacy issues
     * Better class fields managment
     * Better packages naming

commit 03e7cd2
Author: bezmian <[email protected]>
Date:   Fri Feb 3 13:33:05 2017 +0100

    SlideFragmentBuilder now throws Exception when missing necessary properties

commit a0bf6a4
Author: Filip Skowron <[email protected]>
Date:   Fri Feb 3 12:18:35 2017 +0100

    Add annotations (TangoAgency#71)

    * Update gradle version
     * Add proper annotations for Res assets and variables
     * Add @callsuper in needed places

    * Change OnFinish to OnLastSlidePassed
     * Update README.md
     * Rename method in IFinishListener to onFinish

    * Add proper comment to onLastSlidePassed
     * Improve SlideFragmentBuilder scoping access

    * Fix scoping in SlideFragmentBuilder

commit 5dfec3e
Author: Filip Skowron <[email protected]>
Date:   Fri Feb 3 11:42:01 2017 +0100

    Add prefix mis_ for all attributes from attrs.xml (TangoAgency#73)

    * Add prefix mis_ for all attributes from attrs.xml

    * Update README.md

    * Add mis_ prefix to all xml resources
     * Remove unused layout xml

    * Styles now doesn't have mis prefixes
     * Better styles naming

    * Update style name in README.md

commit b5d0795
Author: Filip Skowron <[email protected]>
Date:   Fri Feb 3 11:04:21 2017 +0100

    Fix bug when orientation changes, the screen goes transparent (TangoAgency#72)

    * Fix bug when orientation changes screen goes transparent
     * Improve code quality by extracting code to methods

    * Rename method color to getColorFromRes

    * getBackgroundColor and getButtonsColor now returns int instead of Integer

commit 866260d
Merge: 13515a3 01dd51d
Author: bezmian <[email protected]>
Date:   Tue Jan 31 11:01:11 2017 +0100

    Merge remote-tracking branch 'origin/master' into develop

commit 13515a3
Merge: 6066dd8 bc51c02
Author: Radek Piekarz <[email protected]>
Date:   Thu Dec 1 11:07:21 2016 +0100

    Merged branch develop into develop

commit bc51c02
Merge: e5f34ac 970ebc6
Author: Radek Piekarz <[email protected]>
Date:   Wed Oct 12 11:27:29 2016 +0200

    Merge pull request TangoAgency#30 from TangoAgency/release/0.0.4

    Release/0.0.4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bezmian bezmian

Labels
None yet
Projects
None yet
Milestone
0.0.6
Development

No branches or pull requests
5 participants
@radzio @xp-vit @aexvir @volvciklum @bezmian