Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colors go crazy on last slide when device is rotated #95

Closed
GaryCuevas opened this issue Mar 20, 2017 · 5 comments
Closed

Colors go crazy on last slide when device is rotated #95

GaryCuevas opened this issue Mar 20, 2017 · 5 comments

Comments

@GaryCuevas
Copy link

GaryCuevas commented Mar 20, 2017

Rotating the Android device when the last slide of a series is displayed results in the colors going crazy. Easily reproduced with the supplied sample app.

(This may be related to bug #45 (Single slide intro calculates wrong background color).

@GaryCuevas
Copy link
Author

I set some breakpoints in the code to see what happens when onCreate() is called on screen rotation when that last slide is showing. I saw some code for setting up the slide colors that was explicitly not called in this situation. I tried to work around the problem with various fixes but I ran into trouble.

@bezmian
Copy link
Contributor

bezmian commented Mar 20, 2017

You mean something like this: #64 ?

@GaryCuevas
Copy link
Author

Yes, exactly that. Sorry I didn't see it was already filed.

@GaryCuevas
Copy link
Author

Thanks for pointing this out. I'll have a chance to incorporate the fix when I get back to the office on Wednesday. Really appreciate it!

@GaryCuevas
Copy link
Author

Integrated and it works like a dream! Thanks so much.

Good luck with case #96 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants