Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] The info part of AddActiveCharge is wrong #589

Open
SirWrexes opened this issue Nov 17, 2024 · 0 comments
Open

[Docs] The info part of AddActiveCharge is wrong #589

SirWrexes opened this issue Nov 17, 2024 · 0 comments

Comments

@SirWrexes
Copy link

EntityPlayer:AddActiveCharge()'s documentation mentions the following:

FlashHUD appears to be redundant. Chargebar flashes regardless of using true or false.

However, this is not true.
I've been making an active item that recharges over time but not with room clears, and ended up needing to implement my own clock using MC_POST_UPDATE.

When flashHUD is true, the game produces a sound effect on charge and the bar flickers.
When flashHUD is false, the charge is silent and there is no flicker.

untitled.mp4

Note that I also tried without the "Fancy Charge Bar" mod to make sure it was not involved in this and can confirm it wasn't.
Also due to file size restrictions the quality is mediocre and the flicker is barely very visible--but it is there!

I would open a PR but I'm not entirely sure how to reword it and would gladly do so with some advice. 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant