Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Role model updates #61

Open
takos22 opened this issue Sep 15, 2021 · 0 comments · May be fixed by #63
Open

[BUG] Role model updates #61

takos22 opened this issue Sep 15, 2021 · 0 comments · May be fixed by #63
Labels
bug Something isn't working good first issue Good for newcomers
Milestone
Initial Release

Comments

@takos22
Copy link
Contributor

takos22 commented Sep 15, 2021 •
edited
Loading

The UpdateRoleBody and NewRoleBody have some issues and need some updates, here are the needed updates:

  1. The UpdateRoleBody.name has a max_length of 64 instead of the 32 in NewRoleBody.name.

    API/api/versions/v1/routers/roles/models.py

    Line 24 in 261ecd3

    name: str = Field("", min_length=4, max_length=64)

  2. The NewRoleBody.color and UpdateRoleBody.color could use a pydantic.Color field instead of the current int field.

    API/api/versions/v1/routers/roles/models.py

    Line 19 in 261ecd3

    color: Optional[int] = Field(None, le=0xFFFFFF, ge=0)

    API/api/versions/v1/routers/roles/models.py

    Line 25 in 261ecd3

    color: Optional[int] = Field(None, le=0xFFFFFF, ge=0)

@takos22 takos22 added bug Something isn't working good first issue Good for newcomers labels Sep 15, 2021
@takos22 takos22 added this to the Initial Release milestone Sep 15, 2021
KrishnaKanth1729 added a commit to KrishnaKanth1729/API that referenced this issue Oct 7, 2021
@KrishnaKanth1729
Resolved Issue Tech-With-Tim#61
8729a14
@KrishnaKanth1729 KrishnaKanth1729 linked a pull request Oct 7, 2021 that will close this issue
Open
7 tasks
@mohamed040406 mohamed040406 linked a pull request Oct 8, 2021 that will close this issue
Update role models (fix issue #61) #63
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
Initial Release
Development

Successfully merging a pull request may close this issue.

Update role models (fix issue #61) KrishnaKanth1729/API
1 participant
@takos22