feat: tinymce internationalization #7363
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoran995
force-pushed
the
tinymce-internationalization
branch
from
dd56f8f to
4ca7acf
Compare
zoran995
commented
Dec 11, 2024
|
|
||
| return ( | ||
| <Editor | ||
| key={language} |
There was a problem hiding this comment.
TinyMCE doesn't support dynamic updates of translations after the editor is initialized, so we need to remount it
pjonsson
reviewed
Dec 11, 2024
| @@ -4,6 +4,7 @@ import { Editor } from "@tinymce/tinymce-react"; | |||
| import PropTypes from "prop-types"; | |||
| // eslint-disable-next-line @typescript-eslint/no-unused-vars | |||
| import tinymce from "tinymce"; // must import despite being unused | |||
| import type { Editor as TinyMCEEditor } from "tinymce"; | |||
There was a problem hiding this comment.
I never understood why tinymce must be imported despite being unused. Can the previous line be removed now that something else is imported from tinymce?
There was a problem hiding this comment.
I didn't check that, but type imports will be removed in compile time so those new imports doesn't change anything
zoran995
force-pushed
the
tinymce-internationalization
branch
from
4ca7acf to
0d14c94
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Fixes #7275
Add internationalization support to the TinyMCE editor used in Storybuilder. It follows a similar structure as language overrides. The translation files should be added to
languages/tinymcein wwwroot.Test me
${language}.jsfile towwwroot/languages/tinymce/${language}.jsChecklist
doc/.