Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

follow command ignoring npc's gender #100

Open
riidom opened this issue Nov 4, 2023 · 2 comments
Open

follow command ignoring npc's gender #100

riidom opened this issue Nov 4, 2023 · 2 comments

Comments

@riidom
Copy link

riidom commented Nov 4, 2023

Doing the tutorial, at the point where you get the NPC to charge the torch, I give the command Lara, follow and the game responds Lara nods his head., though Lara is defined with createItem("Lara", NPC(true), {...}).
ThePix added a commit that referenced this issue Nov 6, 2023
@ThePix
Follow/Not follow response now gender neutral
40e09b1 
Thanks to riidom for finding.
#100
Also needs to be in lang!

Also some issues with zones resolved, though this may be on-going!
@ThePix
Copy link
Owner

ThePix commented Nov 6, 2023

Thanks for that. The message was not properly gender neutral, or in the language file, so multiple issues. I have corrected a couple of files, lib/_npc.j nd lang/lang-en.js on GitHub and it should work okay now.

@riidom
Copy link
Author

riidom commented Nov 6, 2023

Thanks for the quick fix! Can't test it, having some errors on master branch, but I guess it's good and issue can be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@riidom @ThePix