Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile styles #23

Open
mvultgmr opened this issue Oct 10, 2020 · 7 comments
Open

Mobile styles #23

mvultgmr opened this issue Oct 10, 2020 · 7 comments

Comments

@mvultgmr
Copy link

Hi, Pix. I had some ideas for adding mobile breakpoints to style.css, so I forked the project and did some revisions. I'm new to GitHub so am not sure if this is the right way to do things, but here is a link to my version. Feel free to play with!

https://github.com/mvultgmr/QuestJS/commit/c4079a2ddd4664aa5661c353788babfae3e73252

@ThePix
Copy link
Owner

ThePix commented Oct 15, 2020

Just to let you know, I am thinking about this. I think it is important, I am not sure the best way to proceed. Part of that is that the author should have some choice about whether the side pane (and anything else, map?) disappears, depending on what the authors thinks is the primary way to play the game.

@mvultgmr
Copy link
Author

Yeah, I wasn't sure immediately what to do with the side pane and map items. The solution usually is to move all that to a hamburger menu; perhaps something for you to think about. In the meantime, you might preserve this code as a starting point for authors who want to attempt it, either as commented-out code or within a help file.

I'm glad the project seems to be going well!

@ThePix
Copy link
Owner

ThePix commented Nov 14, 2020

I have made a small step, it that now features disappear if the width is narrow.
https://github.com/ThePix/QuestJS/wiki/Responsive-Games

May need more consider, eg your hamburger idea; we will see how it goes.

@mvultgmr
Copy link
Author

Great job. Mobile styling is a tedious bitch, but having these features will make things so much more accessible.

Also great job on the map function!

@KVonGit
Copy link
Contributor

KVonGit commented Dec 23, 2020

I tried to check out the code by @mvultgmr, but the link was dead.

One of the things on my QuestJS to-do list is to add the hamburger-style menu for the panes when on mobile.

Also, I wanted to see if those mobile settings were better than my mobile settings (which are rudimentary, at best).

@mvultgmr
Copy link
Author

Shit, sorrry, @KVonGit . I purged the repo once I thought Pix was done with it. But if you'd like to share your code, I'd be be happy to spitball it. :)

@mvultgmr
Copy link
Author

Here is the mobile styling code that I wrote last October, FWIW. I believe a the developer has devised better options for mobile styling since then.
style-mobile.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants