Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embeded video in text block modul #1500

Open
kaxigt opened this issue Apr 23, 2016 · 22 comments
Open

Embeded video in text block modul #1500

kaxigt opened this issue Apr 23, 2016 · 22 comments
Assignees

Comments

@kaxigt
Copy link

kaxigt commented Apr 23, 2016

I'm trying to embed a video via wp media uploader in the text block modul instead of using the specific video modul but it doesn't work. How to fix this?

@kaxigt kaxigt changed the title Embedeb´d video in text block modul Embeded video in text block modul Apr 23, 2016
@ghost
Copy link

ghost commented Apr 25, 2016

Hello,

Sorry, I don't know, I am not a WP Editor expert.

Try to switch to text mode add the embed shortcode manually

[embed]https://www.youtube.com/embed/7mMLlg9ZCJM[/embed]

I will inspect this problem later.

@ghost ghost self-assigned this Apr 25, 2016
@ghost
Copy link

ghost commented Apr 25, 2016

Also you can switch to text mode and add

<iframe width="560" height="315" src="https://www.youtube.com/embed/SOLOZRVNM8w" frameborder="0" allowfullscreen></iframe>

@pear1
Copy link

pear1 commented May 25, 2016

Hello,

Our clients also have complains about this issue.
They are trying to insert videos under tab shortcode container and it is not working.

Are there any news about this issue?

@ghost
Copy link

ghost commented May 25, 2016

Sorry, no news.

@ghost
Copy link

ghost commented Oct 13, 2016

I have tried wp-editor > Add Media > Insert from URL > YouTube link, it throws a js error and the preview is showing endless loading

1476375467997

@ghost ghost assigned andreiglingeanu Oct 13, 2016
@andreiglingeanu
Copy link
Collaborator

@moldcraft It works for me and I'm not able to reproduce that.

@kaxigt
Copy link
Author

kaxigt commented Apr 25, 2017

Sooo, am I understand this right you won't do anything about it regardless the complains?

@andreiglingeanu
Copy link
Collaborator

Well it worked on my side. Have you tried it and it fails for you?

@kaxigt
Copy link
Author

kaxigt commented Apr 25, 2017

Yes I have tried it, and appearently others too without a good result. I tried both on child as parent standard theme.

@danyj
Copy link
Contributor

danyj commented Apr 25, 2017

@andreiglingeanu

Well it worked on my side.

sorry just had to :)

https://varianto25.com/stickers/works-on-my-machine

sorry @kaxigt , im sure it will be looked at

@andreiglingeanu
Copy link
Collaborator

@kaxigt Can you please make a short video out of your problem?

@kaxigt
Copy link
Author

kaxigt commented Apr 25, 2017

Now I have tried again. Embed video doesn't work when upload media in text block. Totally blank.

@andreiglingeanu
Copy link
Collaborator

You mean in frontend?

@warudin
Copy link

warudin commented Jul 18, 2018

Is it me or does adding a YouTube url in a text-block still not work?

When adding a link in a text-block the back-end shows the video, when checking front-end, only the url of the video shows up. When putting [embed] tags around it, nothing shows.

@andreiglingeanu
Copy link
Collaborator

andreiglingeanu commented Jul 18, 2018

Have you tried to pass the text block contents through the do_shortcode() function? This is required for the embeds to fire up.

@warudin
Copy link

warudin commented Jul 18, 2018

I haven't changed the code in the text-block, so this is what happens, which is the default:

<?php echo do_shortcode( $atts['text'] ); ?>

@andreiglingeanu
Copy link
Collaborator

andreiglingeanu commented Jul 18, 2018

There is definitely some differences in the way these editors are implemented... The editor from the Widgets -> Text works expectedly, it properly inlines the Embed URL:

I'll try to dig this... There must be missing some JS functionality for our editor.

No one of you tried to look this more deeper than just reproducing the issue?

@danyj
Copy link
Contributor

danyj commented Jul 18, 2018

@andreiglingeanu

this is what @warudin said

when checking front-end, only the url of the video shows up.

so it means the do_shortcode frontend does not work , but we need to know if @warudin is talking about builder shortcode or the sidebar

@andreiglingeanu
Copy link
Collaborator

I believe he's talking about the builder shortcode. I can reproduce this thing on my side too

@warudin
Copy link

warudin commented Jul 18, 2018

Yeah, this is about the text-block shortcode.

When adding a YouTube, SoundCloud, Vimeo link, a preview shows up in the back-end, but on the front-end we're only seeing a url.

@yura-x
Copy link
Contributor

yura-x commented Oct 31, 2018

Has anyone fixed this issue?
I'm also have this issue. I'm only could show YouTube video in WP-editor by putting whole iframe tag in text mode of editor:
<iframe width="560" height="315" src="https://www.youtube.com/embed/SOLOZRVNM8w" frameborder="0" allowfullscreen></iframe>

@mhsohag11
Copy link

anyone here ??? How can I show a video in a FW block ( type : wp-editor )?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants