ScriptProcessorNode deprecation warnings #88
Comments
gherkins
changed the title
1j01
added a commit
to 1j01/guitar
that referenced
this issue
Apr 9, 2023
1. createScriptProcessor is used in tuna.js anyways, so it will need updating in order to actually do away with the warnings, and avoid future bit rot. Theodeus/tuna#88 https://stackoverflow.com/questions/68007500/how-to-migrate-to-audioworkletnode-from-scriptprocessornode I could send a PR, or perhaps switch to a different effects chain. 2. String bending doesn't work 3. Maybe there's an error that can occur where fret is undefined? Note implicit assignment at play: (@fret)-> Note there's GuitarStringProcessor::play and GuitarString::play
|
I'd like to see node implementations moved to audio worklets (the modern way of implementing custom audio nodes as I understand). |
@felixniemeyer Check out my fork for worklet implementation and type definitions: https://github.com/devindavies/tuna |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Some FX-Types rely on the deprecated ScriptProcessorNode and will produce the following console warning
Happens for example with FX-Types
Chorus,Phaser,Tremolo&WahWahbecause of: https://github.com/Theodeus/tuna/search?q=createScriptProcessor
see
https://developer.mozilla.org/en-US/docs/Web/API/ScriptProcessorNode
https://developer.mozilla.org/en-US/docs/Web/API/BaseAudioContext/createScriptProcessor
https://stackoverflow.com/questions/48874118/porting-scriptprocessor-based-application-to-audioworklet
The text was updated successfully, but these errors were encountered: