Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS - binary data support #53

Open
panta opened this issue Jun 27, 2014 · 6 comments
Open

iOS - binary data support #53

panta opened this issue Jun 27, 2014 · 6 comments
Labels
Milestone

Comments

@panta
Copy link

panta commented Jun 27, 2014

It seems that binary communication is not supported, looking at -[Connection write:] and -[Connection stream:(NSStream*) handleEvent:(NSStreamEvent)], where NSASCIIStringEncoding is used. Is it so? In this case, would it be possible to add binary data support?

@vinnylinck
Copy link

Sure. I'll work to add this feature for next release, is possible.

Thanks for your feedback.
Vinny

-----Original Message-----
From: "Marco Pantaleoni" [email protected]
Sent: ‎6/‎27/‎2014 12:50 PM
To: "Tlantic/cdv-socket-plugin" [email protected]
Subject: [cdv-socket-plugin] iOS - binary data support (#53)

It seems that binary communication is not supported, looking at -[Connection write:] and -[Connection stream:(NSStream*) handleEvent:(NSStreamEvent)], where NSASCIIStringEncoding is used. Is it so? In this case, would it be possible to add binary data support?

Reply to this email directly or view it on GitHub.

@shblythe
Copy link

Hi Vinny,

Excellent work here!

I have a project I'd like to use your plugin with, but I need binary data support as well, for Android in my case.

Do you have any idea how you'll change the API? I assume that because you'd need to keep backwards compatibility you might add a new function, e.g., sendBinary(successCallback,errorCallback,connectionId,data,length) - and this version would send binary data and omit line separators.
If you agree this prototype I can make the change to the js and to the android implementation and send a pull request if you like.

Thanks,

Stephen

@vinnylinck
Copy link

Hi there

Thanks you for using this plugin.
Yes! Feel Free to send a PR containing the changes.

I receites the same sugestionar for ios this Week. I can combine both changes and build a new release.

I'll be looking forward to merge your changes.

Best regards
Vinny

On 30/06/2014, at 15:56, shblythe [email protected] wrote:

Hi Vinny,

Excellent work here!

I have a project I'd like to use your plugin with, but I need binary data support as well, for Android in my case.

Do you have any idea how you'll change the API? I assume that because you'd need to keep backwards compatibility you might add a new function, e.g., sendBinary(successCallback,errorCallback,connectionId,data,length) - and this version would send binary data and omit line separators.
If you agree this prototype I can make the change to the js and to the android implementation and send a pull request if you like.

Thanks,

Stephen


Reply to this email directly or view it on GitHub.

@thomasbrueggemann
Copy link

I am highly interested in iOS binary data support too.
Please keep us updated here on the current status! Thank you.

@jenkins-mrs
Copy link

Right! We are working on a new roadmap for this plugin. There are many different requests. We are compile them to make a plan for this plugin.
Even this way, feel free to contribute with pull requests, if you like it.

Thanks

Vinicius Linck
Manager - Mobility Chief Architect
Skype: vinny.linck | +55 51 3320.1671

From: Thomas Brüggemann [mailto:[email protected]]
Sent: Wednesday, August 27, 2014 9:00 AM
To: Tlantic/cdv-socket-plugin
Subject: Re: [cdv-socket-plugin] iOS - binary data support (#53)

I am highly interested in iOS binary data support too.
Please keep us updated here on the current status! Thank you.


Reply to this email directly or view it on GitHubhttps://github.com//issues/53#issuecomment-53559343.

@felipekm
Copy link
Contributor

@tomaszbrue Feel free to submit a Pull Request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants