-
-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vite 5.4.1 + appPlayground = next is not a function #814
Comments
Hi @rubenfiszel thank you for reporting. Does the problem still exist with vite 6? |
Or is this only a dev server issue and does not occur with the production build? |
@kaisalmen I can't reproduce on my local version of the appPlayground so it might be solved in vite 6, will try to see if it happens in build as well |
@rubenfiszel I consider this one resolved. |
I'm not sure this is a monaco language-client issue but we're on vite 5.4 and the appPlayground had an issue because it relies on importing:
http://localhost:3000/node_modules/@codingame/monaco-vscode-extensions-service-override/assets/webWorkerExtensionHostIframe.html?&vscodeWebWorkerExtHostId=6fdd6fd7-b142-4a8a-8076-3e736882eae4
but at the very least vite 5.4.x has an issue with it because it is then served by:
https://github.com/vitejs/vite/blob/da0caf5f9f25ed1803bfed0193b1d8d7b6a71631/packages/vite/src/node/server/middlewares/static.ts#L121
The fix for vite is here: vitejs/vite#19141 but I wonder if it's not caused by something deeper in the ways assets are bundled. In any case, I thought I would report it here and in vite
The text was updated successfully, but these errors were encountered: