Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data too long for some columns #47

Open
lsuma opened this issue Oct 9, 2017 · 3 comments
Open

Data too long for some columns #47

lsuma opened this issue Oct 9, 2017 · 3 comments
Labels

Comments

@lsuma
Copy link
Collaborator

lsuma commented Oct 9, 2017

Some field/column definitions in database table title tx_publist4ubma2_domain_model_publication should be changed to allow for longer strings (in file ext_tables.sql). In my TYPO3 v8.7 test environment (using fork https://github.com/stweil/publist4ubma2/tree/typo3v8), this lead to some critical errors, in other environments, information may be truncated.

So far, I have detected this problem with the following fields:

url_official, creators, title

I was able to fix the problems locally by changing the definition of these fields from varchar(255) to varchar(1000).

@stweil
Copy link
Member

stweil commented Oct 9, 2017

That sounds reasonable, although it will need one more byte for each of those fields (length stored in 2 bytes instead of 1 byte). Truncation would not be good, especially not for a URL. What is the current maximum length seen in our data?

@stweil stweil added the bug label Oct 9, 2017
@zuphilip
Copy link
Member

zuphilip commented Oct 9, 2017

Please note, that this fork should also be rebase before working too much further (difference 65 commits). 🖐

@lsuma Do you have an example publication for this issue?

What is the current maximum length seen in our data?

I guess, that we have some limits by MADOC, but I don't know them. CC @wagneral

Another uncomfortable size limit I have encountered is in the backend, when I try to enter in the advanced option the url directly (these urls can become really long).

@lsuma
Copy link
Collaborator Author

lsuma commented Oct 10, 2017

For title overlength: Publication with eprint_id 34973 (max. length currently 272)
Fur url_official overlength: Publications with eprint_id 41738, 40767, 41656, 39582, 40757, 37256 (max. length currently 430)
Fur creators overlength: Publication with eprint_id 41720 (max. length currently 323)

So maybe 1000 might not be necessary, but it gives a comfortable margin of tolerance.

One more thing: I just noticed the field url_official is currently spelled url_offical.

Another uncomfortable size limit I have encountered is in the backend, when I try to enter in the advanced option the url directly (these urls can become really long).

In this form?
screenshot_20171010_082300

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants