New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CodeReview TODOs: task_ferro_emi.py #37

Open

burnettear opened this issue Jan 17, 2025 · 0 comments

Collaborator

burnettear commented Jan 17, 2025

Code review of file task_ferro_emi.py

Good:

Input and output data files are present at specified filepaths
Units and formatting of output data is compliant
Header comment has added and made compliant
Comments explain data operations

Bad:

Comments on loading the data via gch4i_data_guide_v3.xlsx are somewhat lacking

TODO:

@nkruskamp See TODO comments here in the code review branch.
Review updated comments and documentation, and approve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment