Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

includesubpages filter gets applied AFTER fetching pages #190

Open
soukupmi opened this issue Jun 24, 2022 · 0 comments
Open

includesubpages filter gets applied AFTER fetching pages #190

soukupmi opened this issue Jun 24, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@soukupmi
Copy link

DynamicPageList3 version: 3.4.6 (8e5ae9c)
MediaWiki version: 1.38.1 (d34e8c5)
PHP version: 7.4.28 (fpm-fcgi)

List of steps to reproduce (step by step, including full links if applicable):

  • Tested for translated pages of the dragons on the Dragontamer wiki
  • gives back the 3 pages preceding the current (including sub-pages)
{{#dpl:
|category=Dragons
|namespace=Dragon
|titlelt=Raging Fire
|ordermethod=sortkey
|order=descending
|count=3
}}
  • Now with the subpages excluded one would expect to still get 3 results
{{#dpl:
|includesubpages=false
|category=Dragons
|namespace=Dragon
|titlelt=Raging Fire
|ordermethod=sortkey
|order=descending
|count=3
}}

What happens?:
The filter is applied after fetching the pages, so only 1 of the 3 pages gets displayed. Unlike every other filter, which is applied while fetching the pages.

What should have happened instead?:
Apply the filter while fetching the pages, like nottitleregexp e.g. and others.

Browser information, screenshots and other applicable information:
image

@soukupmi soukupmi added the bug Something isn't working label Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant