Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving ETags #370

Closed
chriswk opened this issue Dec 28, 2023 · 1 comment
Closed

Improving ETags #370

chriswk opened this issue Dec 28, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@chriswk
Copy link
Member

chriswk commented Dec 28, 2023

Describe the feature request

I want Edge to perform ETag calculations for client keys and the /api/client/features endpoint when we update features instead of calculating it after calculating the response each time.

Background

Currently we use a lot of memory and CPU on each request, even if we end up yielding a 304, since our current ETag middleware is performing the service call and then calculating the hash based on the response byte stream and then passing the response byte stream onto the user.

Solution suggestions

Since we already have code in place that stores all client keys we know about and a method to evaluate whether a key is subsumed by another, calculating ETags could be done on a per client key basis, with only keys subsumed by the key that received an update needing to be updated.

@chriswk chriswk added the enhancement New feature or request label Dec 28, 2023
@sjaanus sjaanus moved this from New to Todo in Issues and PRs Jan 10, 2024
@ivarconr ivarconr moved this from Todo to For later in Issues and PRs May 16, 2024
@chriswk
Copy link
Member Author

chriswk commented Oct 16, 2024

Solved by #390 once it gets merged

@chriswk chriswk closed this as completed Oct 16, 2024
@github-project-automation github-project-automation bot moved this from For later to Done in Issues and PRs Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

No branches or pull requests

2 participants