Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LANGUAGE] Use setlocale to set the locale to support non-ascii environments #83

Open
gynt opened this issue Mar 1, 2024 · 1 comment

Comments

@gynt
Copy link
Collaborator

gynt commented Mar 1, 2024

I am not sure if we should set utf-8 or the users local locale.
https://learn.microsoft.com/en-us/cpp/c-runtime-library/reference/setlocale-wsetlocale?view=msvc-160&viewFallbackFrom=vs-2019#utf-8-support

This requires a slight rewrite of how the extension store is set up, because currently it does an IO operation in the constructor. This needs to be moved to somewhere else in order to allow setlocale to happen before initial IO operations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant