Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #5550 - Improve next sector prediction for PF/PH inbounds to APP #5554

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fixes #5550 - Improve next sector prediction for PF/PH inbounds to APP #5554

wants to merge 2 commits into from
+7 −2

Conversation

hazzas-99
Copy link
Contributor

Fixes #5550

Summary of changes

GUEST ownership added to Galloway sector to allow PF APP and PH APP to receive inbounds from Talla and then descend them into their respective Local Areas whilst technically transiting Galloway's airspace.

Screenshots

Not yet tested.

@hazzas-99 hazzas-99 added the bug Bugs or errors label Jan 6, 2025
@BenWalker01 BenWalker01 mentioned this pull request Jan 13, 2025
Open
@hazzas-99
Copy link
Contributor Author

@BenWalker01 Noticed your comment in the other PR. This might need these lines changed so that TARTN and LANAK are in the FIXBEFORE field (the 2nd one just after 'COPX:')

UK-Sector-File/Agreements/Airport/Tal_PH.txt

Line 1 in 0944fb2

COPX:*:*:TARTN:*:*:Talla:PHAPP:*:8000:|TARTN

UK-Sector-File/Agreements/Airport/Tal_PF.txt

Line 1 in 0944fb2

COPX:*:*:LANAK:*:*:Talla:PFAPP:*:8000:LANAK

@BenWalker01
Copy link
Collaborator

That seems to fix the sector prediction, however the COPX seems to be broken. Unless I've broken something (there is a high possibility of this)
COPX:TARTN:*:TARTN:*:*:Talla:PHAPP:*:8000:|TARTN
COPX:LANAK:*:LANAK:*:*:Talla:PFAPP:*:8000:LANAK
image

@hazzas-99
Copy link
Contributor Author

@BenWalker01 does it work by removing the second instance of TARTN/LANAK? So like:

COPX:TARTN:*:*:*:*:Talla:PHAPP:*:8000:|TARTN
COPX:LANAK:*:*:*:*:Talla:PFAPP:*:8000:LANAK

@BenWalker01
Copy link
Collaborator

BenWalker01 commented Jan 13, 2025 •
edited
Loading

image
Seems to work. 🥳 Some of the far away ones at 260 still show STW, but once they begin the descent it shows the correct radar unit.

Can push the changes here, if needed

@hazzas-99
Copy link
Contributor Author

Yay, yes please @BenWalker01 push away! I think the ones at 260 via AGPED won't show because they're still technically in Montrose airspace, about to enter Deancross. This PR might change that behaviour... #5555

@BenWalker01 BenWalker01 requested a review from PLM1995 January 14, 2025 21:05
@PLM1995
Copy link
Collaborator

PLM1995 commented Jan 17, 2025

KLM327 at FL140 approaching VAPPI still predicting STW (assuming I'm testing it correctly):

image

Similarly with EZY653H when it gets to this position at FL140:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenWalker01 BenWalker01 BenWalker01 approved these changes

@PLM1995 PLM1995 Awaiting requested review from PLM1995

Assignees
No one assigned
Labels
bug Bugs or errors
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect next sector prediction for PF/PH inbounds to APP
3 participants
@hazzas-99 @BenWalker01 @PLM1995