-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Regression] [Bisected] Regression from Explicit Sync related patches causes Proton Games to crash gamescope #1520
Comments
I've seen this crash before on my 7900XTX, and used to be able to make it happen reliably by toggling Frame Generation in Ghost of Tsushima, but I have not seen it in a week or two since verifying I was using up to date Xwayland... which you already are 🤔 are there any games in particular that always crash, or is it all games? Also please give the exact command you're using to launch these. |
Does it occur if you use wined3d? |
@alou-S Do you have a lib32-gamescope package? I was finally able to find out whythe game I was testing kept crashing when changing the window state (happened in both DRM and in nested Wayland), and it was because: 1. I had the WSI layer disabled and 2. I did not have after changing both of those things and running the game with EDIT: realizing now Arch doesn't even package |
@matte-schwartz Firstly I don't think the lib32 layer will help since all the games I tested are 64 bit. I did install the package and it made no difference gamescope still crashes. Setting |
@layercak3 I have tested various configurations
I feel this might be a DXGI related issue since Linux Native Vulkan games run fine and running dx11 games using wined3d works fine too |
Also occurs with upstream wine with DXVK installed. |
Seems like it effects all backends since commit ef3ff8a |
@alou-S Can you share the exact command you're using to launch these so I can see if I can repro it? I have not seen this crash in Deadlock or Dota 2 yet. |
@matte-schwartz |
Played 2 matches of Deadlock earlier today with the in-game Vulkan backend and Gamescope DRM backend without crashing |
|
are you sure you don't have any lingering layers or binaries that may be interfering, i.e. Been working here with Proton Experimental bleeding-edge branch and in-game Vulkan backend, nested gamescope on Plasma Wayland. Also tested with DRM Backend with no issues so far.
Finally, if you re-compile gamescope but change this convar: gamescope/src/Backends/DRMBackend.cpp Line 70 in cc28cd7
to true, does gamescope work again without reverting either of the commits? it applies to both the Wayland and the DRM backends |
The Vulkan layers:
Logs |
I finally see the issue you're running into (after reproing it). The reason enabling the WSI layer didn't work for you is because gamescope/src/steamcompmgr.cpp Line 7345 in cc28cd7
Try Also, regarding |
Even setting I can confirm that the WSI Layer is enabled since I get the following log message
But gamescope still crashes with the same old error. |
do you see it creating swapchains as well, or just in your Proton log or gamescope output you should see:
proton log with WSI enabled and working for reference: that's probably about as much as I'll be able to help here since I'm pretty much out of ideas :/ especially since I can now see what looks to be the same issue as you but I avoid it with WSI usage, which I typically have set as my default. |
@matte-schwartz Okay so I fixed the problem on my end too but I am not sure if its the right way to fix it.
warning at the start of the game. If I press okay and ignore the warning the game starts fine. But the question is, is this a proper way. |
Currently I am also getting the same error when I run any 64-bit game under gamescope nested. I also get this error regardless of whether I select cancel or OK:
The error does not appear for 32-bit games, but eventually both start to stutter constantly and run at 50fps after about 30 minutes. It also crashes if I leave it unfocused for more than five minutes.
Distro: Artix |
@KagoraTheGrindcoreAddict This is not a related bug. I would suggest you to create a new issue. |
@alou-S I'm not really familiar with your specific method of launching games tbh... that error usually means you have conflicting Vulkan layers of some sort, or you're running gamescope within another instance of gamescope. Neither of which is ideal. that error probably goes away if you run embedded steam in gamescope like |
`delete this` doesn't work on non-virtual base classes. Derp. Probably impacts #1520
`delete this` doesn't work on non-virtual base classes. Derp. Probably impacts #1520
Can you try with latest master? |
Thanks, I briefly checked and couldn't get this error anymore with or without the lib32 WSI. Also affects #1519 |
@Joshua-Ashton The issue is fixed. Many thanks for the update! |
`delete this` doesn't work on non-virtual base classes. Derp. Probably impacts ValveSoftware#1520 (cherry picked from commit ddf0d76)
Issue
Only occurs when using the DRM backend and doesn't occur in nested modeLog
System Information
DISPLAY
andWAYLAND_DISPLAY
variablesThe text was updated successfully, but these errors were encountered: