Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

abort() in gamescope::CWaylandInputThread::ThreadFunc #1533

Closed
ninja- opened this issue Sep 19, 2024 · 3 comments
Closed

abort() in gamescope::CWaylandInputThread::ThreadFunc #1533

ninja- opened this issue Sep 19, 2024 · 3 comments

Comments

@ninja-
Copy link

ninja- commented Sep 19, 2024 •
edited
Loading

I can reproduce this every time by following the steps on 3.15.9 with game Stray

Launch options:

ENABLE_GAMESCOPE_WSI=1 DXVK_HDR=1 ENABLE_HDR_WSI=1 gamescope  --force-grab-cursor  -W 3840 -H 2160 -r 240 --hdr-enabled --expose-wayland --hdr-debug-force-output -f -e --mangoapp -- %command%

(monitor is native 4k)

Change resolution in the game to 1920x1080.
Crash

#0  0x00007fdce0dabf24 in __pthread_kill_implementation () at /usr/lib/x86_64-linux-gnu/libc.so.6
#1  0x00007fdce0d5308e in raise () at /usr/lib/x86_64-linux-gnu/libc.so.6
#2  0x00007fdce0d3a882 in abort () at /usr/lib/x86_64-linux-gnu/libc.so.6
#3  0x000055ab22a45f8f in gamescope::CWaylandInputThread::ThreadFunc (this=0x55ab393da150) at ../src/Backends/WaylandBackend.cpp:2358
#4  0x00007fdce10f69f4 in execute_native_thread_routine () at /usr/lib/x86_64-linux-gnu/libstdc++.so.6
#5  0x00007fdce0da9f5d in start_thread () at /usr/lib/x86_64-linux-gnu/libc.so.6
#6  0x00007fdce0e2ea94 in clone () at /usr/lib/x86_64-linux-gnu/libc.so.6

https://github.com/ValveSoftware/gamescope/blob/master/src/Backends/WaylandBackend.cpp#L2361

there are no logs of any kind before the crash happens, it's the first message after resolution change
@ninja-
Copy link
Author

ninja- commented Sep 19, 2024

oops, looks like already reported as 1456

@ninja-
Copy link
Author

ninja- commented Sep 19, 2024

as #1456

@kisak-valve
Copy link
Member

Closing as a duplicate.

@kisak-valve kisak-valve closed this as not planned Won't fix, can't repro, duplicate, stale Sep 19, 2024
layercak3 added a commit to layercak3/gamescope-ghfork that referenced this issue Nov 3, 2024
@layercak3
WaylandBackend: Re-map toplevel upon becoming visible
607b40b 
When becoming invisible, a NULL buffer is attached to the toplevel's
surface which unmaps it. The compositor resets their state and the
surface may also be considered unconfigured. Upon becoming visible, the
surface must be re-mapped using the same process during initialization
(commit without a buffer and wait for configure) before we begin
attaching an actual buffer. The default properties should also be
recovered.

Fixes: ValveSoftware#1456
Fixes: ValveSoftware#1451 (probably)
Fixes: ValveSoftware#1488 (probably)
Fixes: ValveSoftware#1533
@layercak3 layercak3 mentioned this issue Nov 3, 2024
Open
layercak3 added a commit to layercak3/gamescope-ghfork that referenced this issue Nov 3, 2024
@layercak3
WaylandBackend: Re-map toplevel upon becoming visible
f45eabe 
When becoming invisible, a NULL buffer is attached to the toplevel's
surface which unmaps it. The compositor resets their state and the
surface may also be considered unconfigured. Upon becoming visible, the
surface must be re-mapped using the same process during initialization
(commit without a buffer and wait for configure) before we begin
attaching an actual buffer. The default properties should also be
recovered.

Fixes: ValveSoftware#1456
Fixes: ValveSoftware#1451 (probably)
Fixes: ValveSoftware#1488 (probably)
Fixes: ValveSoftware#1533
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ninja- @kisak-valve