MoltenVK integration #761
Open
MoltenVK integration #761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add MoltenVK runtime to package. Update hellovr_vulkan_main.cpp to support MoltenVK. Remove use of CMainApplication::GetVulkanInstanceExtensionsRequired() and CMainApplication::GetVulkanDeviceExtensionsRequired() on macOS. Add SDL_cocoametalview.h/m files to support Metal views. Update CMakeLists.txt files to support Vulkan on macOS via MoltenVK. Replace use of vsprintf_s() with sprintf_s() for safer use on macOS. Update samples/README.md doc to explain compiling samples on macOS.
Remove multisampling if running on macOS. Find Vulkan/Metal device based on compositor device. Use IOSurface for framebuffer and submit IOSurface to compositor. Reorganize directories for MoltenVK components. Add Metal and IOSurface frameworks. Update samples/README.md with macOS/MoltenVK info.
|
I skimmed over this and two minor things I noticed:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.