Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shift to .NET Core #9

Open
NotoriousRebel opened this issue Mar 9, 2020 · 10 comments
Open

Shift to .NET Core #9

NotoriousRebel opened this issue Mar 9, 2020 · 10 comments

Comments

@NotoriousRebel
Copy link

It would be great if this project was targeting .NET Core especially with 3.1 getting LTS for 3 years :)

@NotoriousRebel
Copy link
Author

Any updates?

@stevehayles
Copy link
Contributor

stevehayles commented May 24, 2020

Have a look at my fork and netstandard branch (https://github.com/stevehayles/Quic.NET/tree/netstandard) which is multi-targetting .net4.5.2 and Netstandard2.1

I believe this is a better way to go than specifically creating creating a .NET Core library. This library doesn't need anything outside .NetStandard (at least yet) and this makes it compatible in the widest sense with as many projects as possible

@Vect0rZ
Copy link
Owner

Vect0rZ commented Jun 1, 2020

Hello, @stevehayles ,

thank you for doing so. Currently, your link does not point to any branch, has it been deleted?

@stevehayles
Copy link
Contributor

Hi @Vect0rZ ,

My mistake with the url, I think that should point to the correct fork / branch now

@Vect0rZ
Copy link
Owner

Vect0rZ commented Jun 2, 2020

Great, thank you @stevehayles , looks good

If that's okay for you, let's do a PR and merge it into the main repository.

@stevehayles
Copy link
Contributor

@Vect0rZ Very happy to do a PR, I am actually just checking through the .NET Standard versions as I think it could be dropped to 2.0 which will allow usage with .NET core 2.0, Mono 5.4 and a lower version of Unity.

If that is the case than the full framework would be compatible from version 4.6.1 which would make the multi-targetting to 4.5.2 almost redundant. How important do you think 4.5.2 compatibility is in reality ?

@Vect0rZ
Copy link
Owner

Vect0rZ commented Jun 2, 2020

@stevehayles Good point about Core 2.0.
Not worried at all about 4.5.2 compatibility at this point in the development stage, and I doubt there will be an emerging demand for it. In the unlikely event somebody requests it, we can easily branch and do a specific release.

Thanks!

@Vect0rZ
Copy link
Owner

Vect0rZ commented Jul 7, 2020

@NotoriousRebel @stevehayles Any concerns closing this task?

@stevehayles
Copy link
Contributor

@Vect0rZ No problem for me, it's working fine here. Now to work on the streaming .....

@NotoriousRebel
Copy link
Author

Fine with it being closed thanks for all the help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants