Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intra-function information #25

Open
emesare opened this issue Dec 24, 2024 · 2 comments
Open

Intra-function information #25

emesare opened this issue Dec 24, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@emesare
Copy link
Member

emesare commented Dec 24, 2024

Right now a Function contains information to build a function signature (name, calling convention, type), this would classify as inter-function analysis, i.e. the transition from one Function to another Function would constitute knowing that information, whereas intra-function analysis would be the information internal to a Function.

Examples of intra-function information:

  • Variables
  • Comments
  • Stack pointer adjustments
@emesare emesare added the enhancement New feature or request label Dec 24, 2024
@emesare emesare self-assigned this Dec 24, 2024
@emesare
Copy link
Member Author

emesare commented Dec 24, 2024

I should note comments attached to the function are technically possible through the function type, but that is hardly acceptable. I think functions themselves should have a separate comment metadata, or at least some way other than adding a comment at offset 0, even if the integration does not distinguish between the two.

To clarify "functions themselves" means attached to the function header, rather than showing up within the function body.

@emesare emesare added this to the Gallifrey milestone Dec 24, 2024
@WhatTheFuzz
Copy link

Looks like a great feature. Regarding your note on:

I think functions themselves should have a separate comment metadata, or at least some way other than adding a comment at offset 0...

I totally agree. I frequently add comments at offset 0 to describe what the function is doing. Since WARP is geared toward function signatures anyway, I think this is a great way to initially limit scope.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants