Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shulker box tooltip mod empty spaces are skipped #888

Open
3 of 4 tasks
Kyuunex opened this issue Aug 12, 2024 · 14 comments
Open
3 of 4 tasks

Shulker box tooltip mod empty spaces are skipped #888

Kyuunex opened this issue Aug 12, 2024 · 14 comments
Assignees
Labels

Comments

@Kyuunex
Copy link

Kyuunex commented Aug 12, 2024

/viaversion dump Output

https://dump.viaversion.com/5b6cf01a99802a876de702cfc7f08064697a032417b212476b6f3963438e5aab

Console Error

No response

Bug Description

Server is 1.19.4
I recently upgraded my instance from 1.20.4 to 1.20.6 and noticed the empty spots in my shulker tooltips were skipped. I made sure this is a Via issue and not the Shulker Box Tooltip mod issue.

1.20.4 client:
1.20.4

1.20.6 and 1.21 clients:
1.20.6

This may not seem like a huge issue but it gets annoying on anarchy servers when you are trying to make a kit and need to get it right.

Steps to Reproduce

  1. Install: 1.20.6 or 1.21 client. Mods: ViaFabric, Shulker Box Tooltip and Mod Menu
  2. Launch
  3. In the Mod menu, locate Shulker Box Tooltip and in it's settings toggle on "Swap Modes" and "Always On".
  4. Connect to 1.19.4 server
  5. Hover over a shulker box that has empty slots in between items
  6. Notice the empty slots are skipped

Expected Behavior

Empty slots in the shulker box should exist.

Additional Server Info

No response

Checklist

  • I have checked if this is specific to ViaFabric platform, and doesn't happen when running it on other platforms (Paper/Sponge/Velocity/Waterfall).
  • I have included a ViaVersion dump.
  • If applicable, I have included a paste (not a screenshot) of the error.
  • I have tried the latest build(s) from https://ci.viaversion.com/ and the issue still persists.
@Kyuunex Kyuunex added the bug label Aug 12, 2024
@Kichura
Copy link
Member

Kichura commented Aug 12, 2024

Does this continue when using real 1.19.4 client on same server?

@Kyuunex
Copy link
Author

Kyuunex commented Aug 12, 2024

This issue does not exist when using a real 1.19.4 client on this 1.19.4 server. (not having Via installed)

@Kichura
Copy link
Member

Kichura commented Aug 12, 2024

will be investigated then.

@Kichura
Copy link
Member

Kichura commented Aug 12, 2024

Couldn't seem to reproduce this issue, Can you try this with a clean world save?

This is a 1.20.4 client on fabric 1.19.4 client during my test run:
a

@Kichura Kichura removed the bug label Aug 12, 2024
@Kyuunex
Copy link
Author

Kyuunex commented Aug 12, 2024

perhaps there is some miscommunication
This is what the shulker box in question actually looks like when being opened normally

2024-08-12T14:55:41+00:00

and these empty slots get lost when hovering over with the mod

@Kichura
Copy link
Member

Kichura commented Aug 12, 2024

perhaps there is some miscommunication
This is what the shulker box in question actually looks like when being opened normally

and these empty slots get lost when hovering over with the mod

Tried to copy what your shulker box contains one-by-one and this is what i got:
b
From what i understand about this mod, It sorts the items that have less than 64 to the last slots and the rest seem to be sorted with another mechanism that get sorted otherwise no matter how scrambled it is. (Slime and Iron were in very last two slots)

@Kyuunex
Copy link
Author

Kyuunex commented Aug 12, 2024

here's a simpler repro and world save

client is 1.20.6, world save is 1.19.4 for the server
2024-08-12T16:11:15+00:00
Archive.zip

@Kichura
Copy link
Member

Kichura commented Aug 12, 2024

here's a simpler repro and world save

client is 1.20.6, world save is 1.19.4 for the server

Still seems to be properly sorted, Is your config the default btw?
c

@Kyuunex
Copy link
Author

Kyuunex commented Aug 12, 2024

this is taken on a native 1.19.4 client on the same server
2024-08-12T16:16:30+00:00

regarding the config: In the Mod menu, locate Shulker Box Tooltip and in it's settings toggle on "Swap Modes" and "Always On".

@Kyuunex
Copy link
Author

Kyuunex commented Aug 12, 2024

shulkerboxtooltip.json
this is my config file, rename to shulkerboxtooltip.json5 and put it in the config folder

@Kichura
Copy link
Member

Kichura commented Aug 12, 2024

Now i can reproduce, except i now managed to find the issue itself which tells me that this is not a viafabric-specific issue to some extent. Except if the mod was present on 1.19.4 server then it's busted on 1.20.5+ clients cuz of the custom payload packets being too large.

@Kyuunex
Copy link
Author

Kyuunex commented Aug 12, 2024

This is a non-issue when I play on a 1.20.6 server with a 1.20.6 client (with the same exact Shulker mod). Which is why I figured it may be a Via translation issue.

@Kichura
Copy link
Member

Kichura commented Aug 12, 2024

Going to try this with 1.20.5/6 to see if i can get anything else to change with this as the mod states it also accepts server-side.

@Kichura
Copy link
Member

Kichura commented Aug 12, 2024

Ok it's not busted on 1.20.5+ servers anymore and it properly renders the contents in same slots as it's in actual view, meaning 1.20.4 and older are broken it seems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants