Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ViaVersion and ItemsAdder attributes bug per version #890

Open
4 tasks done
SliderKP opened this issue Sep 19, 2024 · 4 comments
Open
4 tasks done

ViaVersion and ItemsAdder attributes bug per version #890

SliderKP opened this issue Sep 19, 2024 · 4 comments

Comments

@SliderKP
Copy link

/viaversion dump Output

https://dump.viaversion.com/c686ccada17ea1393a067f7b52ed71178eb740c4ec23fe5182d5f8760b5899a2

Console Error

No console errors

Bug Description

bugs occours when a user join with different version at 1.21.1, for example if u join with 1.20.4, durability of armors created by itemsadder goes to default (like leather item) but if u join with 1.21.1 the durability defined by itemsadders works fine:
1.211 item:
image

SAME item on 1.20.4:
image

maybe you going to tell me "the durability looks different but works fine" but that is not correctly, in 1.20.4 the armor only has 50 hits to broke, and in 1.21.1 resists 407 hits.

i reported this to itemsadder developer but considers the problem are with ViaVersion or ViaBackwards.

Steps to Reproduce

1- Join with 1.21.1 and use an armor of itemsadder (works fine)
2- join with 1.20.4 and use the same armor and has the default durability of leather, not only the durability is broken, the "armor level" too

Expected Behavior

the armors have the same durability and attributes on all versions

Additional Server Info

im using PufferFish 1.21.1 build 16

Checklist

  • Via plugins are only running on EITHER the backend servers (e.g. Paper) OR the proxy (e.g. Velocity), not on both.
  • I have included a ViaVersion dump.
  • If applicable, I have included a paste (not a screenshot) of the error.
  • I have tried the latest build(s) from https://ci.viaversion.com/ and the issue still persists.
@Barvalg
Copy link
Member

Barvalg commented Sep 19, 2024

Platform: 1.21.1--16--a9e9d99%20%28MC%3A%201.21.1%29
ViaVersion (5.0.4-SNAPSHOT): Even with master
ViaBackwards(5.0.4-SNAPSHOT): Even with master

@kennytv
Copy link
Member

kennytv commented Sep 19, 2024

1.20.4 simply doesn't have the ability to change the max durability. The only thing we could "fix" is at least keeping the relative amount of durability to the fixed total

@SliderKP
Copy link
Author

1.20.4 simply doesn't have the ability to change the max durability. The only thing we could "fix" is at least keeping the relative amount of durability to the fixed total

i updated my server from 1.20.4, and when i stay on 1.20.4 on my server i see the attributes correctly and the durability too, this broken when i update to 1.21.1 and updated viapluigins

@SliderKP
Copy link
Author

please any way to fix this ?

@FlorianMichael FlorianMichael transferred this issue from ViaVersion/ViaVersion Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants