Breaks Go to Definition for some reason

[sphinxrave]

Describe the bug
Installing the extension breaks typescript go to definition (control click) behavior.

To Reproduce
Steps to reproduce the behavior:

1. install extension
2. observe control click stops working
3. disable extension (refresh)
4. it works again.

Expected behavior
It shouldn't break control click / go to definition.

I reproduced this on a blank repo with a new profile.

[thanhloc-17]

same issue

[karlhorky]

I'm also experiencing this - it may be related to the fixes introduced to resolve conflicts with other VS Code extensions:

• Errors in .mdx files with mdx.checkMdx in tsconfig.json appear at end of file #160
• fix: mdx analyzer plugin conflicts #161

Downgrading the extension to 3.2.0 is a temporary workaround.

[penicillin0]

Same here

[Viijay-Kr]

I will look into it , until then downgrading to 3.2.0 could be a workaround

[Viijay-Kr]

mm 🤔 3.2.1 works for me without any problems .
I wonder if it has anything to do with the plugin initialization . Does none of the extension features work for you or only go to definition is broken ? .

If so can one of you post the settings.json contents and possibly the tsserver log ? (command to get the log >Typescript: open server log) if enabled

Also could you try disabling the plugin using the setting reacTsScss.tsCleanUpDefs and see if it helps ?

[karlhorky]

To be clear, it breaks peek and Go to Definition in TypeScript files too (unrelated to extension features):

Kapture.2024-07-09.at.10.25.55.mp4

Setting "reactTsScss.tsCleanUpDefs": false, does not resolve the issue - still no peek / Go to Definition appearing with cmd-click.

Show `settings.json`

{
  "workbench.startupEditor": "newUntitledFile",
  "editor.wordWrap": "on",
  "editor.minimap.enabled": false,
  "editor.cursorBlinking": "solid",
  "editor.formatOnType": false,
  "editor.formatOnSave": true,
  "files.autoSave": "onFocusChange",
  "editor.folding": false,
  "workbench.colorCustomizations": {
    "statusBar.background": "#303030",
    "statusBar.noFolderBackground": "#222225",
    "statusBar.debuggingBackground": "#511f1f",
    "editor.lineHighlightBackground": "#2f2f2f"
    // Use no-unused-vars from ESLint instead (baseConfig below)
    // "editorUnnecessaryCode.border": "#ff0000"
  },
  "files.trimTrailingWhitespace": true,
  "files.trimFinalNewlines": true,
  "editor.tabSize": 2,
  "workbench.editor.tabSizing": "shrink",
  "window.newWindowDimensions": "maximized",
  "workbench.editor.showIcons": false,
  "explorer.confirmDragAndDrop": false,
  "editor.glyphMargin": false,
  "window.clickThroughInactive": false,
  "javascript.updateImportsOnFileMove.enabled": "always",
  "workbench.editor.closeEmptyGroups": false,
  "workbench.editor.splitSizing": "distribute",
  "prettier.singleQuote": true,
  "editor.defaultFormatter": "esbenp.prettier-vscode",
  "[markdown]": {
    "files.trimTrailingWhitespace": false
  },
  "[plaintext]": {
    "files.trimTrailingWhitespace": false
  },
  "editor.codeActionsOnSave": {
    // Sort package.json keys with
    // https://marketplace.visualstudio.com/items?itemName=unional.vscode-sort-package-json
    "source.sortPackageJson": "always"
  },

  "tsImportSorter.configuration.emptyLinesBetweenGroups": 0,
  "tsImportSorter.configuration.wrappingStyle": "prettier",
  "tsImportSorter.configuration.groupRules": ["^node:", {}, "^[.]"],
  "breadcrumbs.enabled": false,
  "typescript.updateImportsOnFileMove.enabled": "always",
  "workbench.tree.renderIndentGuides": "none",
  "search.searchEditor.reusePriorSearchConfiguration": true,
  // Use an existing Search Editor if there is one, otherwise
  // create a new one
  // https://code.visualstudio.com/updates/v1_53#_default-search-mode
  "search.mode": "reuseEditor",
  // Don't scroll explorer tree when opening a new file
  // https://code.visualstudio.com/updates/v1_46#_explorer-auto-reveal-focus-without-forcing-a-scroll
  "explorer.autoReveal": "focusNoScroll",
  // Use operating system clipboard, available since v1.32.0
  // Original PR:
  // https://github.com/aioutecism/amVim-for-VSCode/pull/260
  // Release:
  // https://github.com/aioutecism/amVim-for-VSCode/issues/276
  "amVim.useSystemClipboard": true,
  // Turn off Debug button above npm scripts in package.json
  // https://github.com/microsoft/vscode/issues/101107#issuecomment-650106018
  "debug.javascript.codelens.npmScripts": "never",
  // Auto-close HTML / JSX tags in MDX
  // https://github.com/silvenon/vscode-mdx/blob/master/readme.md#auto-close-tags
  // https://github.com/formulahendry/vscode-auto-close-tag
  "auto-close-tag.activationOnLanguage": ["mdx"],
  "errorLens.onSave": true,
  "errorLens.onSaveTimeout": 5000,
  "errorLens.scrollbarHackEnabled": true,
  "errorLens.enabledDiagnosticLevels": ["error", "warning", "info"],
  "template-string-converter.validLanguages": [
    "typescript",
    "javascript",
    "typescriptreact",
    "javascriptreact"
  ],
  "template-string-converter.addBracketsToProps": true,
  "template-string-converter.autoRemoveTemplateString": true,
  "editor.inlineSuggest.enabled": true,
  // Instead disable Tab as keybinding for accepting widget
  // suggestions "editor.suggest.selectionMode": "never",
  "github.copilot.enable": {
    "*": false,
    "plaintext": true,
    "markdown": true,
    "scminput": true,
    "yaml": true,
    "css": true,
    "javascript": true,
    "typescript": true,
    "typescriptreact": true,
    "mdx": true,
    "sql": true
  },
  "editor.wordBasedSuggestions": "off",
  "editor.snippetSuggestions": "none",
  // Disable Emmet suggestions
  "emmet.showExpandedAbbreviation": "never",
  "extensions.ignoreRecommendations": true,
  "terminal.integrated.defaultProfile.osx": "zsh",
  "terminal.integrated.scrollback": 100000,
  "terminal.integrated.tabs.enabled": false,
  "terminal.integrated.stickyScroll.enabled": true,
  "editor.stickyScroll.enabled": true,
  "workbench.tree.enableStickyScroll": true,
  "eslint.runtime": "node",
  "redhat.telemetry.enabled": false,
  "javascript.preferences.quoteStyle": "single",
  "typescript.preferences.quoteStyle": "single",
  "editor.lightbulb.enabled": "off",
  "files.associations": {
    ".env": "plaintext"
  },
  "editor.guides.indentation": false,
  "files.insertFinalNewline": true,
  "prettier.trailingComma": "all",
  // , "editor.hover.above": false
  "[yaml]": {
    // Disable CodeLens "GitHub Workflow - YAML Schema for GitHub
    // Workflow (github-workflow.json)" in YAML files
    "editor.codeLens": false
  },
  "editor.linkedEditing": true,
  "workbench.editor.empty.hint": "hidden",
  // Move Activity Bar to the top
  // https://code.visualstudio.com/updates/v1_84#_customize-activity-bar-position
  "workbench.activityBar.location": "top",
  // Highlight occurrences across multiple files
  // https://code.visualstudio.com/updates/v1_84#_multidocument-highlighting
  "editor.occurrencesHighlight": "multiFile",
  // Enable mult-file diff editor
  // https://code.visualstudio.com/updates/v1_85#_multifile-diff-editor
  "multiDiffEditor.experimental.enabled": true,
  "rewrap.wrappingColumn": 65,
  "workbench.editor.tabActionCloseVisibility": false,
  "cSpell.enableFiletypes": ["sql"],
  "cSpell.userWords": [
    "bootcamp",
    "hackathons",
    "katas",
    "Vercel",
    "wireframes"
  ],
  "cSpell.enabledLanguageIds": [
    "asciidoc",
    "c",
    "cpp",
    "csharp",
    "css",
    "git-commit",
    "go",
    "graphql",
    "handlebars",
    "haskell",
    "html",
    "jade",
    "java",
    "javascript",
    "javascriptreact",
    "json",
    "jsonc",
    "latex",
    "less",
    "markdown",
    "php",
    "plaintext",
    "python",
    "pug",
    "restructuredtext",
    "rust",
    "scala",
    "scss",
    "text",
    "typescript",
    "typescriptreact",
    "yaml",
    "yml",
    "mdx"
  ],
  "github.copilot.advanced": {},
  "cssVariables.languages": [
    "scss",
    "postcss",
    "less",
    "css",
    "html",
    "source.css.styled"
  ],
  // Enable feature "Custom labels for open editors" for VS Code 1.88+
  // to allow customizing tab labels to avoid the problem with multiple
  // tabs having the same label eg. `index.ts`
  // https://code.visualstudio.com/updates/v1_88#_custom-labels-for-open-editors
  "workbench.editor.customLabels.patterns": {
    "**/index.*": "${dirname}/${filename}.${extname}",
    "**/page.tsx": "${dirname}/${filename}.${extname}",
    "**/route.ts": "${dirname}/${filename}.${extname}"
  },
  "github.copilot.editor.enableAutoCompletions": true,
  "rewrap.onSave": true
}

Project settings

{
  // Auto-close HTML / JSX tags in MDX
  // https://github.com/silvenon/vscode-mdx/blob/master/readme.md#auto-close-tags
  // https://github.com/formulahendry/vscode-auto-close-tag
  "auto-close-tag.activationOnLanguage": ["mdx"],
  "css.lint.unknownAtRules": "ignore",
  "reactTsScss.autoComplete": true,
  "reactTsScss.baseDir": "src",
  "reactTsScss.cleanUpDefs": [
    "node_modules/vite/client.d.ts",
    "node_modules/next/types/global.d.ts",
    "node_modules/react-scripts/lib/react-app.d.ts"
  ],
  "reactTsScss.codelens": true,
  "reactTsScss.cssAutoComplete": true,
  "reactTsScss.cssDefinitions": true,
  "reactTsScss.cssSyntaxColor": true,
  "reactTsScss.definition": true,
  "reactTsScss.diagnostics": true,
  "reactTsScss.peekProperties": true,
  "reactTsScss.references": true,
  "rewrap.onSave": true,
  "rewrap.wrappingColumn": 65,
  "stylelint.validate": [
    "css",
    "less",
    "scss",
    "postcss",
    "javascript",
    "typescriptreact"
  ],
  "typescript.tsdk": "node_modules/typescript/lib"
}

Extensions:

$ code --list-extensions          
auiworks.amvim
bierner.comment-tagged-templates
bierner.lit-html
bradlc.vscode-tailwindcss
cardinal90.multi-cursor-case-preserve
clinyong.vscode-css-modules
codespaces-contrib.codeswing
dbaeumer.vscode-eslint
dozerg.tsimportsorter
esbenp.prettier-vscode
formulahendry.auto-close-tag
frigus02.vscode-sql-tagged-template-literals-syntax-only
github.copilot
github.copilot-chat
github.remotehub
iceworks-team.iceworks-style-helper
jannisx11.batch-rename-extension
karyfoundation.nearley
kumar-harsh.graphql-for-vscode
mattpocock.ts-error-translator
mechatroner.rainbow-csv
meganrogge.template-string-converter
mrmlnc.vscode-json5
ms-vscode.azure-repos
ms-vscode.remote-repositories
redhat.vscode-commons
redhat.vscode-yaml
rohit-gohri.format-code-action
stkb.rewrap
stylelint.vscode-stylelint
sysoev.vscode-open-in-github
tamasfe.even-better-toml
timonwong.shellcheck
unifiedjs.vscode-mdx
unional.vscode-sort-package-json
usernamehw.errorlens
viijay-kr.react-ts-css
vunguyentuan.vscode-css-variables
wix.glean
wmaurer.change-case

[Viijay-Kr]

@karlhorky yes :D I just realised it all other go to definitions are broken but the extension definition works :D coz I also faced this issue in my company project now and then quickly came back here to post it and you already replied.

So this is super strange , if the plugin changes are reason for this then downstream plugins following this approach should break the definitions no ? did you happen to disable React CSS modules and try it with mdx analyzer ? or may be a vscode styled components or whichever extension that shipped the server plugin using the proxy approach ?

I can try it out later tonight , right now Unfortunately we'd have to live with the mdx analyzer bug (3.2.0)

[Viijay-Kr]

Also I would like to downgrade the plugin within the context of the extension as this bug is super nasty and will affect new users of React CSS modules and don't want to affect new users