Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Curvature Loss is Dimensionally Incorrect #1

Open
bcui19 opened this issue Dec 19, 2019 · 0 comments
Open

Curvature Loss is Dimensionally Incorrect #1

bcui19 opened this issue Dec 19, 2019 · 0 comments

Comments

@bcui19
Copy link

bcui19 commented Dec 19, 2019

Hey I first wanted to say that this is great work. I also wanted to point out that in the non-amortized curvature loss if you look at the shapes:

grad_z is [batchsize x latent_dim]
grad_u is [batchsize x action_dim]

when I think in the paper grad_u should be [batchsize x latent_dim].

So, I think right now the way the curvature loss is formatted it is non-sensical dimensionally since if action_dim ≠ latent_dim or action_dim ≠ 1 then you'd get a dimension mismatch. Let me know if you have any questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant