Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support --check for built-in rules in the fix sub-command #3423

Open
Gedochao opened this issue Jan 15, 2025 · 1 comment
Open

Support --check for built-in rules in the fix sub-command #3423

Gedochao opened this issue Jan 15, 2025 · 1 comment
Labels
enhancement New feature or request experimental Tickets tied to experimental features. missing feature Something should have been implemented, but wasn't. subcommand:fix issues tied to the `fix` sub-command.

Comments

@Gedochao
Copy link
Contributor

Scala CLI version
94a6e37

Is your feature request related to a problem? Please describe.
Currently the --check flag is only supported for scalafix rules, and ignored by built-in rules.
The flag should fail the command if any changes are required to be done by fix, rather than implement them.

Describe the solution you'd like
--check should be supported by all rules in fix, rather than just scalafix
@Gedochao Gedochao added enhancement New feature or request experimental Tickets tied to experimental features. missing feature Something should have been implemented, but wasn't. subcommand:fix issues tied to the `fix` sub-command. labels Jan 15, 2025
@Gedochao Gedochao mentioned this issue Jan 16, 2025
Merged
@bjaglin
Copy link

bjaglin commented Jan 31, 2025

Somewhat-related discussion about unifying the 2 backends behind fix: #3400 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request experimental Tickets tied to experimental features. missing feature Something should have been implemented, but wasn't. subcommand:fix issues tied to the `fix` sub-command.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bjaglin @Gedochao