Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auction Config Passed Macro Replacements Not Working with Some 3P Configurations #1310

Open
thegreatfatzby opened this issue Oct 23, 2024 · 3 comments

Comments

@thegreatfatzby
Copy link
Contributor

Seeing a tricky issue where the macro replacement via the deprecatedReplaceInUrn does work, but the same replacement does not work if done via the auctionConfig.deprecatedRenderURLReplacements. I see this in Stable (which I'm typing this on Version 130.0.6723.70 (Official Build) (arm64)) as well as dev (on other laptop but I believe it was in the 132's).

Test "System"

I have a little toy set up that allows you to see the replacement work (or not) with values you input, the navigator.deprecatedReplaceInUrn one is here and the auctionConfig.deprecatedRenderURLReplacements is here. Both will set up a simple IG that is guaranteed to win a simple auction, and then the query param is sent to the creative rendering server which spits back what it sees as a way of easily knowing that the param was swapped and sent to the server. You can of course just inspect the elements if you like.

Results

The chrome flag that causes/uncauses the issue is #tpc-phase-out-facilitated-testing, so basically (I assume) related to the 3PC state of the browser.

I see the following behavior (for both of the Control2 options my test seems to have some bug I'll need to work on later)
Enabled: Not working via auctionConfig
Enabled Control 1: No
Enabled LabelOnly: No
Enabled Treatment: No
Enabled Control2: test issue
Enabled Force Control1: No
Enabled Force LabelOnly: No
Enabled Force Treatment: No
Enabled Force Control2: test issue
Disabled: works fine

@JacobGo
Copy link
Contributor

JacobGo commented Oct 23, 2024

Looks like you also ran into #286 (comment).

@MattMenke2
Copy link
Contributor

The comments in #286 say it rolled out to stable at 100% back in May, so seem unlikely to be relevant.

@JacobGo
Copy link
Contributor

JacobGo commented Oct 28, 2024

@MattMenke2 from what I understand, Chrome has held back the feature on labeled traffic despite otherwise landing 100% stable, see corresponding logic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants