Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matching declarations, definitions, and comments in motor.h/cpp #12

Open
gcl8a opened this issue Jul 11, 2020 · 1 comment
Open

Matching declarations, definitions, and comments in motor.h/cpp #12

gcl8a opened this issue Jul 11, 2020 · 1 comment

Comments

@gcl8a
Copy link
Member

gcl8a commented Jul 11, 2020

The templates for declarations and definitions match (e.g., float, int, ...) but the names change from .h to .cpp. cpp allows this, but it also leads to contradictions in the comments, I fear. I would fix them for you, but I don't know how particular you are about names. You mostly have 'miliseconds' as a parameter, but msTimeDuration occasionally (note, I did change one set of comments to match, but that's it).

I'd just go with msTimeDuration, if I were you.

@madhephaestus
Copy link
Contributor

yeah, good point. A lot of this code is frankensteined bits of other motor classes i have made over time. It could use a cleaning pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants