Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continuous integration #14

Open
takluyver opened this issue May 3, 2018 · 2 comments
Open

Continuous integration #14

takluyver opened this issue May 3, 2018 · 2 comments

Comments

@takluyver
Copy link
Member

Is a good idea! There are a number of services that are free for open source projects, including Travis CI and Circle CI. We should set up one of these to run the tests automatically on every push and every pull request.

@kirs
Copy link
Contributor

kirs commented May 4, 2018

It would be great to have CI in place.

One thing that could be an issue is that most of CI services assume that the Rails app is in the root of the repo. In our case, it's in the MYR_rails directory.

@takluyver is there any historical reason why it was in a sub-directory? Would you be open to move it to the top directory?

@takluyver
Copy link
Member Author

That was how it was when I inherited it; I think at some point the plan may have been to have the rails app in one directory and an Android frontend in another. Conceptually, I quite like having a separate directory for the tracker hardware details, but if it's going to be a problem, that can be a subfolder inside the rails app.

I'd suggest having a brief look for options to test a rails app that's not the root of the repo. If it's easy to say "look in this directory", we can do that. If not, or if there are other downsides, we can make it the repo root.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants