Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vagrant to run server? #5

Open
takluyver opened this issue Apr 7, 2018 · 2 comments
Open

Vagrant to run server? #5

takluyver opened this issue Apr 7, 2018 · 2 comments

Comments

@takluyver
Copy link
Member

@nicolas2lee I see you started adding a Vagrantfile to run the server in the develop branch. That seems like a sensible thing to have. Did you get it working? Is it ready to merge? We're working on the master branch for the main development.

Is putting the production secret key in the repository a cause for concern? The comment just above that seems to say that's not a good idea.

@nicolas2lee
Copy link
Member

Vagrant is just a tool for development, vagrantfile is useful only when someone like me use vagrant to develop. Anyway I do not think vagrant is used for production.
The vagrant config works in my part, if you need vagrant, then maybe you could merge it. Otherwise I think it my stay in the develop branch, since I do not have enough time to work on the project.
The production secret key should never been put in the repo, anyway it should be configured in the production server.
I do not know how you organize branches. But for me, at least, a branch iso-prod (e.g.: master) where the code is same as production code except some secret configs, a branch develop which is the main development branch. Developers should not commit on develop branch (when a lot of things added) directly, a new branch for a new feature, once validated, merge into develop branch, once delivered on prod, then merge into master.

@takluyver
Copy link
Member Author

I think I use master the way you use develop, and tag a release when you would merge into master.

We've found some local Ruby developers who're interested in helping us develop the site for this year's competition. So I'll leave this open for now and they can decide whether they want to use a Vagrantfile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants