From be6f7c2c7ae5764082d6ebd50e5bea2303a31813 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Felix=20N=C3=BCsse?= <felix.nuesse@t-online.de>
Date: Mon, 27 Nov 2023 22:18:58 +0100
Subject: [PATCH 1/3] remove requirement to draw over other apps
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Signed-off-by: Felix Nüsse <felix.nuesse@t-online.de>
---
 ui/src/main/AndroidManifest.xml               |  3 ---
 .../com/wireguard/android/QuickTileService.kt | 27 ++++++++++++-------
 .../android/activity/TunnelToggleActivity.kt  |  1 +
 ui/src/main/res/values/strings.xml            |  1 +
 ui/src/main/res/values/styles.xml             |  5 +++-
 5 files changed, 24 insertions(+), 13 deletions(-)

diff --git a/ui/src/main/AndroidManifest.xml b/ui/src/main/AndroidManifest.xml
index 754992d5d..72617f3b1 100644
--- a/ui/src/main/AndroidManifest.xml
+++ b/ui/src/main/AndroidManifest.xml
@@ -7,9 +7,6 @@
     <uses-permission android:name="android.permission.INTERNET" />
     <uses-permission android:name="android.permission.RECEIVE_BOOT_COMPLETED" />
     <uses-permission android:name="android.permission.REQUEST_INSTALL_PACKAGES" />
-    <uses-permission
-        android:name="android.permission.SYSTEM_ALERT_WINDOW"
-        android:minSdkVersion="34" />
     <uses-permission
         android:name="android.permission.WRITE_EXTERNAL_STORAGE"
         android:maxSdkVersion="28"
diff --git a/ui/src/main/java/com/wireguard/android/QuickTileService.kt b/ui/src/main/java/com/wireguard/android/QuickTileService.kt
index 9be2cc2bd..8991e6369 100644
--- a/ui/src/main/java/com/wireguard/android/QuickTileService.kt
+++ b/ui/src/main/java/com/wireguard/android/QuickTileService.kt
@@ -5,6 +5,7 @@
 package com.wireguard.android
 
 import android.app.PendingIntent
+import android.content.Context
 import android.content.Intent
 import android.graphics.Bitmap
 import android.graphics.Canvas
@@ -52,6 +53,7 @@ class QuickTileService : TileService() {
     }
 
     override fun onClick() {
+        updateTile()
         when (val tunnel = tunnel) {
             null -> {
                 val intent = Intent(this, MainActivity::class.java)
@@ -64,21 +66,22 @@ class QuickTileService : TileService() {
                 }
             }
             else -> {
+                Log.e("TAG", "click")
                 unlockAndRun {
                     applicationScope.launch {
                         try {
                             tunnel.setStateAsync(Tunnel.State.TOGGLE)
                             updateTile()
                         } catch (_: Throwable) {
-                            if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.UPSIDE_DOWN_CAKE && !Settings.canDrawOverlays(this@QuickTileService)) {
-                                val permissionIntent = Intent(Settings.ACTION_MANAGE_OVERLAY_PERMISSION, Uri.parse("package:$packageName"))
-                                permissionIntent.addFlags(Intent.FLAG_ACTIVITY_NEW_TASK)
-                                startActivityAndCollapse(PendingIntent.getActivity(this@QuickTileService, 0, permissionIntent, PendingIntent.FLAG_IMMUTABLE))
-                                return@launch
+                            Log.e("TAG", "click?")
+                            val intent = Intent(this@QuickTileService, TunnelToggleActivity::class.java)
+                            intent.addFlags(Intent.FLAG_ACTIVITY_NEW_TASK)
+                            if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.UPSIDE_DOWN_CAKE) {
+                                startActivityAndCollapse(PendingIntent.getActivity(this@QuickTileService, 0, intent, PendingIntent.FLAG_IMMUTABLE))
+                            } else {
+                                @Suppress("DEPRECATION")
+                                startActivity(intent)
                             }
-                            val toggleIntent = Intent(this@QuickTileService, TunnelToggleActivity::class.java)
-                            toggleIntent.addFlags(Intent.FLAG_ACTIVITY_NEW_TASK)
-                            startActivity(toggleIntent)
                         }
                     }
                 }
@@ -133,7 +136,7 @@ class QuickTileService : TileService() {
         isAdded = false
     }
 
-    private fun updateTile() {
+    private fun updateTile(isConnecting: Boolean = false) {
         // Update the tunnel.
         val newTunnel = Application.getTunnelManager().lastUsedTunnel
         if (newTunnel != tunnel) {
@@ -148,6 +151,12 @@ class QuickTileService : TileService() {
             null -> {
                 tile.label = getString(R.string.app_name)
                 tile.state = Tile.STATE_INACTIVE
+                if(isConnecting) {
+                    if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.Q) {
+                        tile.subtitle = getString(R.string.quick_settings_tile_connecting)
+                        tile.state = Tile.STATE_ACTIVE
+                    }
+                }
                 tile.icon = iconOff
             }
             else -> {
diff --git a/ui/src/main/java/com/wireguard/android/activity/TunnelToggleActivity.kt b/ui/src/main/java/com/wireguard/android/activity/TunnelToggleActivity.kt
index 59b9349f5..1142e8b08 100644
--- a/ui/src/main/java/com/wireguard/android/activity/TunnelToggleActivity.kt
+++ b/ui/src/main/java/com/wireguard/android/activity/TunnelToggleActivity.kt
@@ -48,6 +48,7 @@ class TunnelToggleActivity : AppCompatActivity() {
 
     override fun onCreate(savedInstanceState: Bundle?) {
         super.onCreate(savedInstanceState)
+        moveTaskToBack(true)
         lifecycleScope.launch {
             if (Application.getBackend() is GoBackend) {
                 val intent = GoBackend.VpnService.prepare(this@TunnelToggleActivity)
diff --git a/ui/src/main/res/values/strings.xml b/ui/src/main/res/values/strings.xml
index df3d33406..c3a849a53 100644
--- a/ui/src/main/res/values/strings.xml
+++ b/ui/src/main/res/values/strings.xml
@@ -257,4 +257,5 @@
     <string name="biometric_prompt_private_key_title">Authenticate to view private key</string>
     <string name="biometric_auth_error">Authentication failure</string>
     <string name="biometric_auth_error_reason">Authentication failure: %s</string>
+    <string name="quick_settings_tile_connecting">Connecting…</string>
 </resources>
diff --git a/ui/src/main/res/values/styles.xml b/ui/src/main/res/values/styles.xml
index 39c382478..120886c2a 100644
--- a/ui/src/main/res/values/styles.xml
+++ b/ui/src/main/res/values/styles.xml
@@ -33,9 +33,12 @@
         <item name="android:windowBackground">@android:color/transparent</item>
         <item name="android:background">@android:color/transparent</item>
         <item name="colorPrimaryDark">@android:color/transparent</item>
-        <item name="android:backgroundDimEnabled">true</item>
+        <item name="android:backgroundDimEnabled">false</item>
         <item name="android:windowEnterAnimation">@android:anim/fade_in</item>
         <item name="android:windowExitAnimation">@android:anim/fade_out</item>
+        <item name="android:windowIsFloating">true</item>
+        <item name="android:colorBackgroundCacheHint">@null</item>
+
     </style>
 
     <style name="TvTheme" parent="AppTheme">

From 8dc6952dd5fe9fc00f43e3b77cc0b2b52b2f5e01 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Felix=20N=C3=BCsse?= <felix.nuesse@t-online.de>
Date: Mon, 27 Nov 2023 23:16:39 +0100
Subject: [PATCH 2/3] remove unnessessary logging
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Signed-off-by: Felix Nüsse <felix.nuesse@t-online.de>
---
 ui/src/main/java/com/wireguard/android/QuickTileService.kt | 2 --
 1 file changed, 2 deletions(-)

diff --git a/ui/src/main/java/com/wireguard/android/QuickTileService.kt b/ui/src/main/java/com/wireguard/android/QuickTileService.kt
index 8991e6369..27b999cb2 100644
--- a/ui/src/main/java/com/wireguard/android/QuickTileService.kt
+++ b/ui/src/main/java/com/wireguard/android/QuickTileService.kt
@@ -66,14 +66,12 @@ class QuickTileService : TileService() {
                 }
             }
             else -> {
-                Log.e("TAG", "click")
                 unlockAndRun {
                     applicationScope.launch {
                         try {
                             tunnel.setStateAsync(Tunnel.State.TOGGLE)
                             updateTile()
                         } catch (_: Throwable) {
-                            Log.e("TAG", "click?")
                             val intent = Intent(this@QuickTileService, TunnelToggleActivity::class.java)
                             intent.addFlags(Intent.FLAG_ACTIVITY_NEW_TASK)
                             if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.UPSIDE_DOWN_CAKE) {

From 055983864b82b661764ae078b05d35f43cc8419c Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Felix=20N=C3=BCsse?= <felix.nuesse@t-online.de>
Date: Wed, 29 Nov 2023 04:02:45 +0100
Subject: [PATCH 3/3] add dummy-progressbar if app was not in foreground
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Signed-off-by: Felix Nüsse <felix.nuesse@t-online.de>
---
 .../com/wireguard/android/QuickTileService.kt |  2 +
 .../android/activity/TunnelToggleActivity.kt  | 36 +++++++++++++--
 ui/src/main/res/layout/loading_activity.xml   | 44 +++++++++++++++++++
 3 files changed, 79 insertions(+), 3 deletions(-)
 create mode 100644 ui/src/main/res/layout/loading_activity.xml

diff --git a/ui/src/main/java/com/wireguard/android/QuickTileService.kt b/ui/src/main/java/com/wireguard/android/QuickTileService.kt
index 27b999cb2..92d1a1bba 100644
--- a/ui/src/main/java/com/wireguard/android/QuickTileService.kt
+++ b/ui/src/main/java/com/wireguard/android/QuickTileService.kt
@@ -22,6 +22,7 @@ import androidx.databinding.Observable
 import androidx.databinding.Observable.OnPropertyChangedCallback
 import com.wireguard.android.activity.MainActivity
 import com.wireguard.android.activity.TunnelToggleActivity
+import com.wireguard.android.activity.TunnelToggleActivity.Companion.SHOW_PROGRESS
 import com.wireguard.android.backend.Tunnel
 import com.wireguard.android.model.ObservableTunnel
 import com.wireguard.android.util.applicationScope
@@ -74,6 +75,7 @@ class QuickTileService : TileService() {
                         } catch (_: Throwable) {
                             val intent = Intent(this@QuickTileService, TunnelToggleActivity::class.java)
                             intent.addFlags(Intent.FLAG_ACTIVITY_NEW_TASK)
+                            intent.putExtra(SHOW_PROGRESS, true)
                             if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.UPSIDE_DOWN_CAKE) {
                                 startActivityAndCollapse(PendingIntent.getActivity(this@QuickTileService, 0, intent, PendingIntent.FLAG_IMMUTABLE))
                             } else {
diff --git a/ui/src/main/java/com/wireguard/android/activity/TunnelToggleActivity.kt b/ui/src/main/java/com/wireguard/android/activity/TunnelToggleActivity.kt
index 1142e8b08..9e70f0768 100644
--- a/ui/src/main/java/com/wireguard/android/activity/TunnelToggleActivity.kt
+++ b/ui/src/main/java/com/wireguard/android/activity/TunnelToggleActivity.kt
@@ -7,6 +7,7 @@ package com.wireguard.android.activity
 import android.content.ComponentName
 import android.os.Build
 import android.os.Bundle
+import android.os.Handler
 import android.service.quicksettings.TileService
 import android.util.Log
 import android.widget.Toast
@@ -24,6 +25,9 @@ import kotlinx.coroutines.launch
 
 @RequiresApi(Build.VERSION_CODES.N)
 class TunnelToggleActivity : AppCompatActivity() {
+
+    private var mIsVisible = false
+
     private val permissionActivityResultLauncher =
         registerForActivityResult(ActivityResultContracts.StartActivityForResult()) { toggleTunnelWithPermissionsResult() }
 
@@ -38,17 +42,23 @@ class TunnelToggleActivity : AppCompatActivity() {
                 val message = getString(R.string.toggle_error, error)
                 Log.e(TAG, message, e)
                 Toast.makeText(this@TunnelToggleActivity, message, Toast.LENGTH_LONG).show()
-                finishAffinity()
+                exitActivity()
                 return@launch
             }
             TileService.requestListeningState(this@TunnelToggleActivity, ComponentName(this@TunnelToggleActivity, QuickTileService::class.java))
-            finishAffinity()
+            exitActivity()
         }
     }
 
     override fun onCreate(savedInstanceState: Bundle?) {
         super.onCreate(savedInstanceState)
-        moveTaskToBack(true)
+
+        if(intent.getBooleanExtra(SHOW_PROGRESS, false)) {
+            mIsVisible = true
+            title = "" // Otherwise the apptitle will be shown above the spinner.
+            setContentView(R.layout.loading_activity)
+        }
+
         lifecycleScope.launch {
             if (Application.getBackend() is GoBackend) {
                 val intent = GoBackend.VpnService.prepare(this@TunnelToggleActivity)
@@ -59,9 +69,29 @@ class TunnelToggleActivity : AppCompatActivity() {
             }
             toggleTunnelWithPermissionsResult()
         }
+        exitActivity()
+    }
+
+    private fun exitActivity() {
+        /*
+         We add this delay, so that the user gets the impression we are actually doing something.
+         This is to make the transition of the closing quicktile-menu more palatable,
+         because startActivityAndCollapse() will immediately close that menu.
+         This can be jarring, so we show this placeholder spinner and close it after a second.
+         */
+
+        if(mIsVisible) {
+            Handler().postDelayed({
+                finishAffinity()
+            }, 1000L)
+        } else {
+            finishAffinity()
+        }
+
     }
 
     companion object {
         private const val TAG = "WireGuard/TunnelToggleActivity"
+        const val SHOW_PROGRESS = "ShowLoadingbar"
     }
 }
diff --git a/ui/src/main/res/layout/loading_activity.xml b/ui/src/main/res/layout/loading_activity.xml
new file mode 100644
index 000000000..0e322ef3d
--- /dev/null
+++ b/ui/src/main/res/layout/loading_activity.xml
@@ -0,0 +1,44 @@
+<?xml version="1.0" encoding="utf-8"?>
+<layout xmlns:android="http://schemas.android.com/apk/res/android"
+    xmlns:app="http://schemas.android.com/apk/res-auto"
+    xmlns:tools="http://schemas.android.com/tools">
+
+    <androidx.constraintlayout.widget.ConstraintLayout
+        android:layout_width="match_parent"
+        android:layout_height="match_parent">
+
+
+        <com.google.android.material.card.MaterialCardView
+            android:layout_width="wrap_content"
+            android:layout_height="wrap_content"
+            android:checkable="true"
+            android:focusable="true"
+            app:contentPadding="32dp"
+            app:layout_constraintBottom_toBottomOf="parent"
+            app:layout_constraintEnd_toEndOf="parent"
+            app:layout_constraintStart_toStartOf="parent"
+            app:layout_constraintTop_toTopOf="parent">
+
+            <LinearLayout
+                android:layout_width="match_parent"
+                android:layout_height="match_parent"
+                android:orientation="vertical">
+
+                <TextView
+                    android:id="@+id/textView"
+                    android:layout_width="wrap_content"
+                    android:layout_height="wrap_content"
+                    android:layout_marginBottom="24dp"
+                    android:text="Preparing Tunnel..." />
+
+                <ProgressBar
+                    android:id="@+id/progressBar"
+                    style="?android:attr/progressBarStyle"
+                    android:layout_width="match_parent"
+                    android:layout_height="match_parent" />
+            </LinearLayout>
+
+        </com.google.android.material.card.MaterialCardView>
+
+    </androidx.constraintlayout.widget.ConstraintLayout>
+</layout>